- Koha-bugs - lists.koha-community.org

[Bug 15977] New: Optional double screen message in Patron Info/Status
by bugzilla-daemon＠bugs.koha-community.org 20 Nov '23

20 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15977 Bug ID: 15977 Summary: Optional double screen message in Patron Info/Status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com This code in MsgType.pm: $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode}, $server ) if ( $server->{account}->{send_patron_home_library_in_af} ); produces two AFs if you enable that attribute in your config. Not sure if that should be the case and is conform protocol. Also: are we solving a problem here in the wrong place? It looks kind of inappropriate use.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 34680] New: Renewal due date -> different due times (HH:MM) depending on the input method
by bugzilla-daemon＠bugs.koha-community.org 20 Nov '23

20 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34680 Bug ID: 34680 Summary: Renewal due date -> different due times (HH:MM) depending on the input method Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: irina.halminen(a)joensuu.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Created attachment 155028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155028&action=e… Renewal due date When setting a renewal due date from the bottom of the circulation page (/cgi-bin/koha/circ/circulation.pl? -> Check out) and typing the due date by hand (not selecting it from the calendar) and pressing Enter, the system sets the due time (HH:MM) automatically, and it differs from the default. For example, our due time is set to be 23:59, but when I type in the renewal due date, it sets the due time to be 00:00. So if the due date is October 31st and the due time is 00:00, all the loans are overdue a minute after the midnight on the due date. Using the calendar and using the manual typing method should both end up in the same result (default HH:MM). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 34939] New: When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59
by bugzilla-daemon＠bugs.koha-community.org 20 Nov '23

20 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34939 Bug ID: 34939 Summary: When manually entering dates in flatPickr the hour and minute get set to 00:00 not 23:59 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org With flatPickr you can manually enter a date. If that date date allows for the input of hours and minutes and you do not manually specify those the default will be 00:00. When you use the flatPickr calendar to pick a date time and no do specify the hour/minute it will default to 23:59. This should be consistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 26

[Bug 35367] New: Add option to link an ordered item to a suggestion after the order has been created
by bugzilla-daemon＠bugs.koha-community.org 20 Nov '23

20 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35367 Bug ID: 35367 Summary: Add option to link an ordered item to a suggestion after the order has been created Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Sometimes library staff forget to add an order to a basket from a suggestion, even though the relevant suggestion exists and has been accepted. It would be great to have an option to link a suggestion to an order after it has been created. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 20 Nov '23

20 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david(a)davidnind.com --- Comment #49 from David Nind <david(a)davidnind.com> --- I've tested and signed off. But feel free to change back to "Needs signoff" if this isn't sufficient. (I'm always nervous about testing circulation and fine rules - "Here be dragons".) Testing notes using KTD: 1. Set the "All All" rule as follows: - Unit: change from Days to Hours - Suspension in days (day): change from blank to 2 - Max. suspension duration (day): left blank - Suspension charging interval: 1 2. Items checked out on 20 November 2023. 3. Results before the patch was applied (I set the due date for an item to 11/09/2023). When checked in, the message says: "[Patron name] is now debarred until 06/05/2055." 4. After the patch was applied, the message on check in says: "[Patron name] is now debarred until 12/10/2023." - Matches what was expected: difference between due date and checked in date = 10; x2 = 20 days = 12/10/2023 5. I then set "Suspension in days (day)" to 1. The message on check in says: "[Patron name] is now debarred until 11/30/2023." - Matches what was expected: difference between due date and checked in date = 10; x1 = 10 days = 11/30/2023 6. The tests pass: prove t/db_dependent/Circulation/maxsuspensiondays.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 20 Nov '23

20 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159076|0 |1 is obsolete| | --- Comment #48 from David Nind <david(a)davidnind.com> --- Created attachment 159129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159129&action=e… Bug 14293: Rebasing tests --Including:-- Bug 14293: Add more tests and improve get_chargeable_units Not sure at all about this change, especially because it could modify CalcFine Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Bug 14293: Add more tests and fix floor/ceil Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 20 Nov '23

20 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159075|0 |1 is obsolete| | --- Comment #47 from David Nind <david(a)davidnind.com> --- Created attachment 159128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159128&action=e… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: Nick Clemens <nick(a)quecheelibrary.org> Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 20 Nov '23

20 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13870] Add warnings about subscriptions and orders when deleting items
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '23

17 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13870 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Hi, my $i_order = GetOrderFromItemnumber($itemnumber); my $i_serialid = Koha::Serial::Items->search( {itemnumber => $itemnumber} )->get_column('serialid'); Is there a performance impact ? Better prefetch linked tables maybe. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11029] Marc Language Code in a list
by bugzilla-daemon＠bugs.koha-community.org 17 Nov '23

17 Nov '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11029 Phil Ringnalda <phil(a)chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paivi.knuutinen(a)joensuu.fi --- Comment #5 from Phil Ringnalda <phil(a)chetcolibrary.org> --- *** Bug 35340 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

1 0