- Koha-bugs - lists.koha-community.org

[Bug 28010] New: add plugin to modify record in "opac-detail.pl"
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28010 Bug ID: 28010 Summary: add plugin to modify record in "opac-detail.pl" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)trust-box.at QA Contact: testopia(a)bugs.koha-community.org Created attachment 118560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118560&action=e… patch to opac-detail.pl I (guess I) need the abiltiy to change how records are beeing display in in opac-detail.pl Specifically I want to change the content of a record depending if a user is logged in or not for ebook renting So it would be great to have the ability to have a plugin hook there, something like 1 diff --git a/opac-detail.pl.orig b/opac-detail.pl 2 index e74cf4b..b46eb90 100755 3 --- a/opac-detail.pl.orig 4 +++ b/opac-detail.pl 5 @@ -217,6 +217,16 @@ if ( $xslfile ) { 6 $variables = { %$variables, %$plugin_variables }; 7 } 8 9 + $record = Koha::Plugins->call_apply( 10 + 'munge_record', 11 + $record, 12 + { 13 + patron => $patron, 14 + interface => 'opac', 15 + caller => 'opac-detail', 16 + } 17 + ); 18 + additionally I have a proposal to extend/modify the plugin system a little bit: I don't like the idea very much that the caller of a plugin has to take care of merging the results so the first step would be to add the ability that a plugin works recursively on a variable diff --git a/Plugins.pm.orig b/Plugins.pm index 11d44dc..71461de 100644 --- a/Plugins.pm.orig +++ b/Plugins.pm @@ -82,6 +82,35 @@ sub call { return @responses; } +=head2 call_apply + +Calls a plugin method for all enabled plugins, reworking on the same input and returning it. +ideally the caller of a plugin must not know how to merge the results +so maybe also implement a "merge" method in the plugin + + @responses = Koha::Plugins->call_apply($method, $work_var, @args) + +=cut + +sub call_apply { + my ($class, $method, $work_var, @args) = @_; + + if (C4::Context->config('enable_plugins')) { + my @plugins = $class->new({ enable_plugins => 1 })->GetPlugins({ method => $method }); + @plugins = grep { $_->can($method) } @plugins; + foreach my $plugin (@plugins) { + my $work_var = eval { $plugin->$method($work_var, @args) }; + if ($@) { + warn sprintf("Plugin error (%s): %s", $plugin->get_metadata->{name}, $@); + next; + } + } + + } + return $work_var; +} + + =head2 GetPlugins In another my idea would be to have an optional "merge" method for a certain type of plugins to avoid code like 206 207 my @plugin_responses = Koha::Plugins->call( 208 'opac_detail_xslt_variables', 209 { 210 biblio_id => $biblionumber, 211 lang => $lang, 212 patron_id => $borrowernumber 213 214 } 215 ); 216 for my $plugin_variables ( @plugin_responses ) { 217 $variables = { %$variables, %$plugin_variables }; 218 } 219 and be able to write something along the lines of 206 207 my $variables = Koha::Plugins->call( 208 'opac_detail_xslt_variables', + $variables, 209 { 210 biblio_id => $biblionumber, 211 lang => $lang, 212 patron_id => $borrowernumber 213 214 } 215 ); I hope I haven't packed to much into one issue, thanks a lot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 32352] New: xt/check_makefile.t failing on node_modules
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Bug ID: 32352 Summary: xt/check_makefile.t failing on node_modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org 21:55:20 koha_1 | # Failed test 'All directories must be listed in Makefile.PL' 21:55:20 koha_1 | # at xt/check_makefile.t line 39. 21:55:20 koha_1 | # got: '1' 21:55:20 koha_1 | # expected: '0' 21:55:20 koha_1 | # $VAR1 = [ 21:55:20 koha_1 | # './node_modules' 21:55:20 koha_1 | # ]; -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #66 from Andrii Nugged <nugged(a)gmail.com> --- (In reply to Andrii Nugged from comment #65) > Yet it was when I tried to religion from an older session, can't reproduce > 1:1 now, but giving a warning now for team + researching myself further. Own update: it's because $userid also comes empty to that code lines (in cases when old session? thinking aloud) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34892] New: Convert RestrictedPageContent system preference to HTML customization
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34892 Bug ID: 34892 Summary: Convert RestrictedPageContent system preference to HTML customization Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 26050 Building on 22318, the RestrictedPageContent system preference should be converted to an HTML customization. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 [Bug 26050] [OMNIBUS] Convert system preferences to HTML customizations -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 34779] New: Pages: Remove "Appear in position?"
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34779 Bug ID: 34779 Summary: Pages: Remove "Appear in position?" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org The manual says that "Appear in position" has no effect on pages. So should we not hide/remove this setting? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Andrii Nugged <nugged(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged(a)gmail.com --- Comment #65 from Andrii Nugged <nugged(a)gmail.com> --- (In reply to David Nind from comment #63) > Created attachment 155540 [details] [review] > Bug 15504: (follow-up) Migrate to one clear method my $patron = Koha::Patrons->find({ userid => $userid }); $patron->update_lastseen('login'); I've got one case when it returned empty $patron, so that led to: [ERROR] Can't call method "update_lastseen" on an undefined value at /usr/share/koha/lib/C4/Auth.pm line xxx. Yet it was when I tried to religion from an older session, can't reproduce 1:1 now, but giving a warning now for team + researching myself further. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34906] New: barcodes issue
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34906 Bug ID: 34906 Summary: barcodes issue Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nasralyashassan(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Hi, I have a problem with my Koha system I have some books in my system and I have assigned a barcode to each book in opac I have the barcode for each book but the issue is when I want to check out one of the books it gives me this barcode does not available in the database and when I go to the database there is no barcodes. So how can I fix this? any help! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 33918] New: Improve translation of title tags: Patron card creator
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33918 Bug ID: 33918 Summary: Improve translation of title tags: Patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 33906 This patch will modify patron card creator templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 33927] New: Improve translation of title tags: Tools
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33927 Bug ID: 33927 Summary: Improve translation of title tags: Tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 33906 This patch will modify tools templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 33919] New: Improve translation of title tags: Patron clubs
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33919 Bug ID: 33919 Summary: Improve translation of title tags: Patron clubs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 33906 This patch will modify patron clubs templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.

1 11