- Koha-bugs - lists.koha-community.org

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Blou <philippe.blouin(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Copy guarantee email to |Redirect guarantee email to |guarantor (or redirect if |guarantor |guarantee has no email set) | --- Comment #166 from Blou <philippe.blouin(a)inlibro.com> --- A big big Thank You! Martin. We have rebased this patch for so long, and it is sooo far from our initial commit... I'm very happy it finally came through. You gave it the final, needed, push. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Copy guarantee email to guarantor (or redirect if guarantee has no email set)
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Redirect guarantee email to |Copy guarantee email to |guarantor |guarantor (or redirect if | |guarantee has no email set) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #165 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- OK, this took a lot more finagling to make it QA happy than I was hoping.. but the time is spent now and the feature seems good to go to me. Passing QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #164 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155946&action=e… Bug 12532: (follow-up) Catch more cases in tests This patch added lots more cases to the unit tests to try and catch all the new functionality. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155886|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155945&action=e… Bug 12532: Fix test The mock was working. The problem was that the to_address of the notice was set from the previous send. A fix would be to update the message, but it seems better to simply re-enqueue it. This patch also use Koha::Notice::Messages. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155883|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155944&action=e… Bug 12532: (QA follow-up) Fix issues highlighted by unit tests * YesNo preferences yield '1' or '0' not 'yes' and 'no'. * Set message_cc address so we can report later that the message went to a cc address. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155882|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155943&action=e… Bug 12532: DBIC Schema Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155881|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155942&action=e… Bug 12532: Expose CC address in patron notices display Add the CC address into the patrons notices on the staff client to highlight that the message was copied to another user. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155880|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155941&action=e… Bug 12532: (QA follow-up) Add cc_address to message_queue Add the cc_address field to the message_queue so we may report back that an email was copied to the guarantor email addresses. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12532] Redirect guarantee email to guarantor
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '23

20 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155879|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 155940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155940&action=e… Bug 12532: (QA follow-up) Add tests for SendQueuedMessages This patch adds unit tests for the changes made to _send_message_by_email for Guarantor CC Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0