- Koha-bugs - lists.koha-community.org

[Bug 32894] New: Objects cache methods' result without invalidation
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Bug ID: 32894 Summary: Objects cache methods' result without invalidation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, tomascohen(a)gmail.com In some of our Koha:: objects we have methods that cache their result and return it in subsequent calls. However there is no invalidation of the cache if the object is modified. For instance, in Koha/ArticleRequest.pm sub biblio { my ($self) = @_; $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() ); return $self->{_biblio}; } This pattern exists in several places. It can lead to confusion and incorrect results, such as: use Koha::ArticleRequests; my $ar = Koha::ArticleRequest->new({ borrowernumber => 42, biblionumber => 42, })->store; say $ar->biblio->biblionumber; # Display 42, correct $ar->set({ biblionumber => 24 })->store; say $ar->biblio->biblionumber; # Display 42, wrong $ar->discard_changes; say $ar->biblio->biblionumber; # Display 42, wrong $ar->delete; We should remove those caching and rely on DBIC/DBMS caching mechanism instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 60

[Bug 15341] Performance - Retrieve all sysprefs at once
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #25 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Katrin Fischer from comment #24) > (In reply to David Cook from comment #23) > > Looks like an old one, but I've often wondered why we haven't fetched all > > the system preferences at once to avoid subsequent calls to the database. > > > > I suppose it does introduce overhead though as you are getting everything > > when in practice you might only use a few preferences. And the more > > preferences you have, the slower that fetch will become. It wouldn't scale. > > > > I suppose the L1/L2 caching we have now should take care of this, although > > I'm trying to see where the L2 cache gets intialized... > > Joubu, reading this, would you agree we can close this bug? No, I still think this is a good one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154948|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 154950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154950&action=e… Bug 8838: Add digest option for HOLD notice Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new digest option for "Hold filled" messages 5) Trap multiple holds for a patron 6) Note a single notices is generated for all the trapped holds! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Assignee|koha-bugs(a)lists.koha-commun |kyle(a)bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154947|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 154948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154948&action=e… Bug 8838: Add digest option for HOLD notice Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new digest option for "Hold filled" messages 5) Trap multiple holds for a patron 6) Note a single notices is generated for all the trapped holds! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8838] Digest option for HOLD notice
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 154947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154947&action=e… Bug 8838: Add digest option for HOLD notice Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Restart all the things! 4) Enable the new digest option for "Hold filled" messages 5) Trap multiple holds for a patron 6) Note a single notices is generated for all the trapped holds! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 34072] New: Holds queue search interface hidden on small screens
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Bug ID: 34072 Summary: Holds queue search interface hidden on small screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewfh(a)dubcolib.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The search interface for the holds queue (view_holdsqueue.pl) is hidden on small/narrow screens. To recreate in Chrome: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 34554] New: Item status In Transit doesn't update after Check In
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34554 Bug ID: 34554 Summary: Item status In Transit doesn't update after Check In Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: azmikhalib(a)utm.my QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Item status in the staff interface does not change from "In Transit " to "Available" but in OPAC status follows changes according to the setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 34359] New: Can we get rid of Koha/BiblioUtils ?
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34359 Bug ID: 34359 Summary: Can we get rid of Koha/BiblioUtils ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org This is not used (only by itself): git grep BiblioUtils::Iterator Koha/BiblioUtils/Iterator.pm:package Koha::BiblioUtils::Iterator; Koha/BiblioUtils/Iterator.pm:Koha::BiblioUtils::Iterator - iterates over biblios provided by a DBIx::Class::ResultSet Koha/BiblioUtils/Iterator.pm: use Koha::BiblioUtils::Iterator; Koha/BiblioUtils/Iterator.pm: my $iterator = Koha::BiblioUtils::Iterator->new($rs); t/db_dependent/Koha/BiblioUtils/Iterator.t:use_ok('Koha::BiblioUtils::Iterator'); t/db_dependent/Koha/BiblioUtils/Iterator.t:my $iterator = Koha::BiblioUtils::Iterator->new($rs, items => 1 ); I know that someone kind of hates Util modules :) Unfortunately we cannot (yet) remove Koha::BiblioUtils module: Koha/BiblioUtils.pm:package Koha::BiblioUtils; Koha/BiblioUtils.pm:Koha::BiblioUtils - contains fundamental biblio-related functions Koha/BiblioUtils.pm: my $biblio = Koha::BiblioUtils->new($marc_record, [$biblionumber]); Koha/BiblioUtils.pm:Creates an instance of C<Koha::BiblioUtils> based on the marc record. If known, Koha/BiblioUtils.pm: my $biblio = Koha::BiblioUtils->get_from_biblionumber($biblionumber, %options); Koha/BiblioUtils.pm:This will give you an instance of L<Koha::BiblioUtils> that is the biblio that Koha/BiblioUtils.pm: my $it = Koha::BiblioUtils->get_all_biblios_iterator(%options); Koha/BiblioUtils.pm:Koha::BiblioUtils of each biblio. This will include the item data. Koha/BiblioUtils.pm: my $marc = Koha::BiblioUtils->get_marc_biblio($bibnum, %options); misc/release_notes/release_notes_22_05_00.html:<li><a href="http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625">[29625]</a> Wrong var name in Koha::BiblioUtils get_all_biblios_iterator</li> misc/release_notes/release_notes_22_05_00.md:- [[29625]](http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29625) Wrong var name in Koha::BiblioUtils get_all_biblios_iterator misc/search_tools/rebuild_elasticsearch.pl:use Koha::BiblioUtils; misc/search_tools/rebuild_elasticsearch.pl: return ($r, Koha::BiblioUtils->get_from_biblionumber($r, item_data => 1 )); misc/search_tools/rebuild_elasticsearch.pl: my $records = Koha::BiblioUtils->get_all_biblios_iterator(%iterator_options); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34627 [Bug 34627] Fix CMS page HTML structure so that footer content is displayed correctly -- You are receiving this mail because: You are watching all bug changes.

1 0