- Koha-bugs - lists.koha-community.org

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #174 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157608&action=e… Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #173 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157607&action=e… Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #172 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157606&action=e… Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #171 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157605&action=e… Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #170 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157604&action=e… Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #169 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157603&action=e… Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Andrii Nugged <nugged(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156917|0 |1 is obsolete| | Attachment #156918|0 |1 is obsolete| | Attachment #156919|0 |1 is obsolete| | Attachment #156920|0 |1 is obsolete| | Attachment #156921|0 |1 is obsolete| | Attachment #156922|0 |1 is obsolete| | Attachment #156923|0 |1 is obsolete| | Attachment #156924|0 |1 is obsolete| | Attachment #156925|0 |1 is obsolete| | Attachment #156926|0 |1 is obsolete| | Attachment #156927|0 |1 is obsolete| | Attachment #156928|0 |1 is obsolete| | Attachment #156929|0 |1 is obsolete| | Attachment #156930|0 |1 is obsolete| | Attachment #156931|0 |1 is obsolete| | Attachment #156932|0 |1 is obsolete| | Attachment #156933|0 |1 is obsolete| | Attachment #156934|0 |1 is obsolete| | Attachment #156935|0 |1 is obsolete| | --- Comment #168 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157602&action=e… Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Andrii Nugged <nugged(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12310] Decimal separators issues in patrons payments/fines
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '23

21 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #146 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- bug 33028 looks like to be mostly about cron and circulation rules, right? So it's not helping for this on and it's successor, bug 21507 :( -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15196] Order patrons on patron lists by name
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '23

21 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15196 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32742 -- You are receiving this mail because: You are watching all bug changes.

1 0