- Koha-bugs - lists.koha-community.org

[Bug 13706] Deduping authorities script (dedup_authorities.pl)
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '23

31 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #14 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I came here looking through old bugs - a new past time of mine. I am setting to NSO then. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34449] New: Staff without manage_sysprefs permission see 'Search system preferences' search box
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '23

31 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34449 Bug ID: 34449 Summary: Staff without manage_sysprefs permission see 'Search system preferences' search box Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When a user is viewing the background-jobs, they see a system preference search even without permission To test: 1 - Grant a user 'catalogue' permission 2 - Browse directly to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 3 - See the system preference search box 4 - Attempt a search 5 - You are told you don't have permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13706] Deduping authorities script (dedup_authorities.pl)
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '23

31 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- We use this in production as-is - if you like it Katrin, feel free to sign-off - I would like it all to be covered by tests but don't know when I will have a chance to work on that -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '23

31 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 Andreas Roussos <a.roussos(a)dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos(a)dataly.gr -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13811] Silent Cronjobs
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '23

31 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13811 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #6 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #5) > I believe maybe instead of a --silent we should have a --verbose? +1 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12421] No way to get back to search results from overdrive results
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153539|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 154078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154078&action=e… Bug 12421: no way to get back to search results from overdrive results When on your search results you can click the link to overdrive results, but then you can't get back to your catalog search results, the line that links to the results should be there on both pages. Test Plan: 1) Apply this patch 2) Enable Overdrive searching 3) Perform a search 4) View the overdrive results 5) Note the "Catalog search for '$q'" link in the breadcrumbs 6) Click the link 7) Note you return to the search results page Signed-off-by: Barry Cannon <bc(a)interleaf.ie> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12421] No way to get back to search results from overdrive results
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12421] No way to get back to search results from overdrive results
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 mathieu saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #111 from mathieu saby <mathsabypro(a)gmail.com> --- Works as described, but note that the syspref is now named EmailFieldPrimary -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 30 Jul '23

30 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Biblibre Sandboxes <sandboxes(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153540|0 |1 is obsolete| | --- Comment #110 from Biblibre Sandboxes <sandboxes(a)biblibre.com> --- Created attachment 154076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154076&action=e… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. Signed-off-by: Mathieu Saby <mathsabypro(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0