- Koha-bugs - lists.koha-community.org

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|matthias.meusburger@biblibr |julian.maurice(a)biblibre.com |e.com | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #108 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch rebased on master. Ready to be tested again -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149232|0 |1 is obsolete| | --- Comment #107 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 153540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153540&action=e… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 33963] New: Remove C4::BackgroundJob
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33963 Bug ID: 33963 Summary: Remove C4::BackgroundJob Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 33962 No more occurrences! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33962 [Bug 33962] Remove C4::BackgroundJob from process_koc -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 33962] New: Remove C4::BackgroundJob from process_koc
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33962 Bug ID: 33962 Summary: Remove C4::BackgroundJob from process_koc Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 2608 The last occurrence of C4::BackgroundJob is in process_koc.pl that is used to upload a file. Added by bug 2608 (15 years ago), I think it does not longer make sense as networks are faster, and we should not expect big koc files to be uploaded. If there are complains we will move it to Koha::BackgroundJob. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2608 [Bug 2608] offline circ processing of large KOC files can time out -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 12421] No way to get back to search results from overdrive results
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|no way to get back to |No way to get back to |search results from |search results from |overdrive results |overdrive results --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- So.. who can test Overdrive? We might want to nudge some people here :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12732] Add basket creation date to late orders table for sorting
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|simith.doliveira(a)inlibro.co |oleonard(a)myacpl.org |m | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12732] Add basket creation date to late orders table for sorting
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12732] Add basket creation date to late orders table for sorting
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12732 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12421] no way to get back to search results from overdrive results
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 --- Comment #8 from Owen Leonard <oleonard(a)myacpl.org> --- I rebased this patch and added the missing filter while I was at it. I'm usually not crazy about controls which simply mimic the back button, but I like the improved clarity in the breadcrumbs so I think this is a good case for it. -- You are receiving this mail because: You are watching all bug changes.

1 0