- Koha-bugs - lists.koha-community.org

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #50 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13956] Add budget information to funds pull down on creating an order
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13956 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31459 --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I was just about to file this as a new bug... Bug 31459 added lovely top headings with the budget name. I think these would be nice to have every where in the acquisitions module, but starting with the form for creating order lines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #49 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 142015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142015&action=e… Bug 14783: Update atomicupdate syntax Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #48 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 142014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142014&action=e… Bug 14783: Compiled CSS Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #47 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 142013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142013&action=e… Bug 14783: (QA follow-up) Rename method and move tests Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #46 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 142012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142012&action=e… Bug 14783: (QA follow-up) Add unit tests. This commit adds unit tests for Bug 14783. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #45 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 142011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142011&action=e… Bug 14783: (QA follow-up) Change "Pick up location" to "Pickup location" in table. Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #44 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 142010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142010&action=e… Bug 14783: (follow-up) Move pickup library form into modal This patch attemps to simplify the list of holds by moving the form for changing a hold's pickup library into a modal dialog. This patch also makes minor tweaks to the CSS for the "X" close button shown in modal in windows. Instances where modal markup used "x" have been updated to use the Bootstrap 4 standard "×" To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staf…) - Turn on the OPACAllowUserToChangeBranch system preference. - Log in to the OPAC as a user with holds. - In the view of your holds, confirm that each hold which can be modified shows a "Change" link. - Clicking the link should show a modal window with the title of the item on hold shown in the header. - Confirm that changing the pickup location works correctly. Signed-off-by: Barbara Johnson <barbara.johnson(a)bedfordtx.gov> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14783] Allow patrons to change pickup location for non-waiting holds
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '22

17 Oct '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783 --- Comment #43 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 142009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142009&action=e… Bug 14783: Change pickup location from opac. This patch allows users to change the pickup location for their holds from the opac. A syspref (OPACAllowUserToChangeBranch) controls at what stage a hold can be changed. To test: 1. Set up holds with diffrent statuses for a patron (pending, waiting, in transit, suspended) 2. No pickup locations for any hold should be able to be changed. 3. Turn on and off the different options under OPACAllowUserToChangeBranch. Make sure that only the corresponding holds can be changed from the opac. Check eg in the staff client that pickup location has changed. 4. The available pickup locations should respect any transfer restrictions. (Same as the holds list for a biblio in staff client) 5. For an in-transit hold: Check in the item at the original pickup location. 6. Note that it will be redirected to the new location. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Barbara Johnson <barbara.johnson(a)bedfordtx.gov> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0