- Koha-bugs - lists.koha-community.org

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139041|0 |1 is obsolete| | --- Comment #45 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140799&action=e… Bug 12285: Don't print fines with undef amountoutstanding Accountlines with undefined amountoutstading value are printed in fineslip. To test: 1) Find patron with credit type accountlines. 2) Edit some of those lines from database, set their amountoutstanding as NULL. 3) Print fineslip. => Note that edited credit lines are displayed in the fineslip. 4) Apply patch. 5) Print fineslip. => Note that lines are no longer displayed in the fineslip. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139040|0 |1 is obsolete| | --- Comment #44 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140798&action=e… Bug 12285: (follow-up) Correct extra quote in yml file Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139039|0 |1 is obsolete| | --- Comment #43 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140797&action=e… Bug 12285: Use accountlines date if issue is not found Printing fines slip would raise error if patron has manually created invoice. In these cases use accountlines date instead of issues date_due. Also silence error: "Argument "" isn't numeric in numeric comparison (<=>)" Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139038|0 |1 is obsolete| | --- Comment #42 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140796&action=e… Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12285] Allow easy printing of patron's fines
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139037|0 |1 is obsolete| | --- Comment #41 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 140795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140795&action=e… Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> Rebased-by: Emmi Takkinen <emmi.takkinen(a)koha-suomi.fi> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 31204] New: Edit dropdown on results.tt should indicate it is record modification
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31204 Bug ID: 31204 Summary: Edit dropdown on results.tt should indicate it is record modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org On results.tt there is an option to select records and then, from the toolbar, select edit and choose either 'Batch edit' or 'Batch delete'. Some librarians have found this confusing, thinking it would lead them to 'Batch Item Modification' when instead it leads to 'Batch record modification'. We could make it less confusing by clearly indicating this function takes the user to record modification, not item modification. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 --- Comment #33 from David Nind <david(a)davidnind.com> --- (In reply to Marcel de Rooy from comment #29) > Here is another (temporary) link. It works now and at least until monday: > https://prod-intra.rijkskoha.nl/bug12758.xsl > Use it for Results XSL. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138201|0 |1 is obsolete| | --- Comment #32 from David Nind <david(a)davidnind.com> --- Created attachment 140792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140792&action=e… Bug 12758: Add new module call in Koha::XSLT::Base Reviving a report back from 2014. The workaround is now moved to a separate helper module from another patch. Test plan: Test OPACXSLTDetailsDisplay with an https reference. You may try: https://library.rijksmuseum.nl/opac-tmpl/bootstrap/en/xslt/zztest.xsl If you flush and restart, the opac detail pages will contain the text 'This is my MARC record.'. NOTE: If you point to an xslt file over https that contains includes or imports, you will still get the error: Failed to load external entity. To address that, we need to extend the _resolve_includes sub. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138200|0 |1 is obsolete| | --- Comment #31 from David Nind <david(a)davidnind.com> --- Created attachment 140791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140791&action=e… Bug 12758: Introduce Koha::XSLT::HTTPS This module now fetches a https stylesheet and returns it as a string to Base. (As a workaround waiting for a real solution in the underlying libraries.) The module can be extended to resolve includes but this requires parsing the xslt code. Test plan: [1] Run t/Koha_XSLT_HTTPS.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12758] Failure when loading or parsing XSLT stylesheets over HTTPS
by bugzilla-daemon＠bugs.koha-community.org 20 Sep '22

20 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12758 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138199|0 |1 is obsolete| | --- Comment #30 from David Nind <david(a)davidnind.com> --- Created attachment 140790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140790&action=e… Bug 12758: Make LWP::Protocol::https required module Moving from recommends to required in cpanfile. Reference info: Debian package liblwp-protocol-https-perl is available for Buster (6.07-2) and Bullseye (6.10-1). Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0