- Koha-bugs - lists.koha-community.org

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137720|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140250&action=e… Bug 3150: (follow-up) Fixing errors and notices Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137719|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140249&action=e… Bug 3150: (follow-up) Add missing bracket Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137718|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140248&action=e… Bug 3150: (follow-up) Reformat notices, don't send if no sender email This patch reformats the notices so that the is_html flag is disabled and the notices display better It also throws an error if trying to send an email but the logged in borrower has no valid email address. Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137717|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140247&action=e… Bug 3150: (follow-up) HTML filtering TT notices and removing old files Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137716|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 140246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140246&action=e… Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #108 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Agree with Katrin.. I'm not close enough to this code to do the rebase.. not sure what's changed to cause the conflict so unpicking the diff is challenging. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #107 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 137716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137716 Bug 3150: Move emails for sending cart and list contents to notices Review of attachment 137716: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=315…) ----------------------------------------------------------------- ::: basket/sendbasket.pl @@ +101,5 @@ > + my $user_email = $patron->first_valid_email_address || C4::Context->preference('KohaAdminEmailAddress'); > + C4::Letters::EnqueueLetter({ > + letter => $letter, > + message_transport_type => 'email', > + borrowernumber => $patron->borrowernumber, I'm not sure we should be setting borrowernumber here.. it's somewhat misleading as the notice will appear as being sent to this borrower under their notices.. we don't really have the directionality in the UI to clearly show if a message was inbound or outbound so I don't know that it should be tied to the user here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '22

07 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #106 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Katrin Fischer from comment #80) > I think I have confused it with another thing we did a while ago as an > anti-Spam measure (bug 24588) > > I am not sure if it has to do with the from address, but there are other > notices we send or potentially send from KohaAdminEmailAddress, like the > cart emails. > > Martin, as you pointed it out, do we need to keep (and maybe move to a > separate report to make it consistent) or can we drop that here? I think we can probably drop it actually.. I can't find anywhere in the wider world that recognises that header at all. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23342] New: Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23342 Bug ID: 23342 Summary: Branch Transfer Limits branch_transfer_limits.pl DBI to Koha::Object, fix variable semantics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: olli-antti.kivilahti(a)hypernova.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com branch_transfer_limits.pl uses DBI SQL statements in the controller. Replace those with Koha::Objects. change branchcode to fromBranch to clarify what is the purpose of the branchcode. Prepare for more BranchTransferLimit authorised value limiting types. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 10

[Bug 7960] Choice to not show the text labels for item types
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '22

06 Sep '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7960 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |class "itypetext" around | |item type descriptions so | |they can be hidden with | |CSS. To hide the | |descriptions, add | |.itypetext { display:none; | |} to the OPACUserCSS (for | |the OPAC) or | |IntranetUserCSS (for the | |staff interface) system | |preferences. -- You are receiving this mail because: You are watching all bug changes.

1 0