- Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30874 --- Comment #212 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Jonathan Druart from comment #206) > (In reply to Shi Yao Wang from comment #204) > > Fixed mentioned errors except "Koha::Patron::Categories->find". It would > > require a new variable near the beginning of the script (after "my > > $categorycode ...") that stores > > "Koha::Patron::Categories->find($categorycode)" and would also require > > changing every place where the script uses it for consistency. I don't know > > if it's a good idea to do it here. Maybe a separate bug? > > Agreed, please open it. Done, see bug 30874 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30874 [Bug 30874] Simplify patron category handling in memberentry -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10950] Add preferred pronoun field to patron record
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10950 Ray Delahunty <r.delahunty(a)arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty(a)arts.ac.uk --- Comment #10 from Ray Delahunty <r.delahunty(a)arts.ac.uk> --- Following a number of complaints relating to gender self-identity we have changed our data feed from the university registry system to pull the 'Preferred name' rather than the 'Given name' from that system and use that to populate the borrowers.firstname . When we move to using API available in 21.05 we will also be massively trimming back what is included in the borrowers table and will be removing title and sex (for example) as they are not relevant to the services we provide. We are being offered a 'personal pronoun' and I think we will store this in borrowers.sort1 for now, and display it to library staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #211 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 135523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135523&action=e… Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #210 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 135522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135522&action=e… Bug 12446: Fix typos Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> JD Amended patch: squashed and edited commit message Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #209 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 135521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135521&action=e… Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #208 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 135520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135520&action=e… Bug 12446: Schema update Category.pm Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135506|0 |1 is obsolete| | Attachment #135507|0 |1 is obsolete| | Attachment #135508|0 |1 is obsolete| | Attachment #135510|0 |1 is obsolete| | Attachment #135511|0 |1 is obsolete| | Attachment #135512|0 |1 is obsolete| | --- Comment #207 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 135519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135519&action=e… Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 01 Jun '22

01 Jun '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #206 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Shi Yao Wang from comment #204) > (In reply to Jonathan Druart from comment #196) > > Can you please review the whole patch set carefully to make it ready for QA? > > > > It took me 3 min to catch trivial errors: > > * merge marker > > +<<<<<<< HEAD > > > > * installer/data/mysql/nb-NO/2-Valgfritt/patron_categories.sql > > has been removed, this patch set reintroduce it > > > > * in members/memberentry.pl there are 2 calls to search_with_library_limits > > > > * still memberentry.pl > > You are adding yet another fetch of the patron category: > > Koha::Patron::Categories->find > > It's fetched several times already in the same script > > > > * t/db_dependent/Patrons.t l.206: extra spaces > > Fixed mentioned errors except "Koha::Patron::Categories->find". It would > require a new variable near the beginning of the script (after "my > $categorycode ...") that stores > "Koha::Patron::Categories->find($categorycode)" and would also require > changing every place where the script uses it for consistency. I don't know > if it's a good idea to do it here. Maybe a separate bug? Agreed, please open it. -- You are receiving this mail because: You are watching all bug changes.

1 0