- Koha-bugs - lists.koha-community.org

[Bug 12599] IndependentBranches Holes
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28967 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 18637] New: Handle Free Text vendor notes on Edifact Quotes
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18637 Bug ID: 18637 Summary: Handle Free Text vendor notes on Edifact Quotes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org At present we store servicing instructions from the GIR segment of the quote in vendornote field of the order. We dont process the FTX segment (segment 25) of the quote. Some vendors (Ebsco) do use this for important information so we need to expand handling to handle Servicng instructions in GIR segment (both coded and free text) and vendor notes in FTX (both free text and coded ) and be able to include these in the generated orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #161 from David Cook <dcook(a)prosentient.com.au> --- I don't think this patch takes into account C4::Reserves::CancelExpiredReserves which gets called by the cronjob /usr/share/koha/bin/cronjobs/holds/cancel_expired_holds.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #160 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 118021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118021 Bug 8367: Add holds_pickup_period circulation rule Review of attachment 118021: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=836…) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ +272,5 @@ > </ul> > > + [% IF pickup_delays %] > + <p id="pickup_delay" style="display:none;">When your item is ready for pickup, you will have <span id="pickup_delay_days"></span> days to pick it up from this library.</p> > + [% END %] This doesn't display for any bibs but the first one if you have multiple bibs to place holds on. @@ +490,5 @@ > + var selected_branch = $("#branch_1").val(); > + [% FOREACH branchcode IN pickup_delays.keys %] > + var branchcode = "[% branchcode | html %]"; > + if ( branchcode == selected_branch ) { > + $("#pickup_delay_days").text([% pickup_delays.$branchcode | html %]); #pickup_delay_days can't work because it's not biblio-specific, so this will break if you're placing holds on more than 1 bib at a time. @@ +499,4 @@ > $(document).ready(function() { > + calculate_delay_days(); > + $("#pickup_delay").show(); > + $("#branch_1").change(function(){ This has the same selector problem because it's hard-coded to biblionumber 1. ::: opac/opac-reserve.pl @@ +694,5 @@ > + }); > + $hold_pickup_delay_by_branch{$branch->branchcode} = $rule->rule_value if ( $rule and $rule->rule_value ); > +} > + > +$template->param( pickup_delays => \%hold_pickup_delay_by_branch ); "pickup_delays" is a confusing name, and it looks like there's no consideration of ReservesMaxPickUpDelay here, even though Hold.pm seems to take it into consideration... which could lead to confusing displays. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #159 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 118021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118021 Bug 8367: Add holds_pickup_period circulation rule Review of attachment 118021: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=836…) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt @@ +486,5 @@ > $(radios).first().attr("checked", "checked"); > } > > + function calculate_delay_days(){ > + var selected_branch = $("#branch_1").val(); This #branch_1 is wrong, as the HTML is populated using "branch_[% bibitemloo.biblionumber | html %]". The current code would only ever work for biblio 1. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #158 from David Cook <dcook(a)prosentient.com.au> --- I'm finding this test plan a bit difficult to follow. What does "7) Revert the waiting status" mean? -- Repeating Rhonda's mention that the pickup message doesn't change for "8) Re-place the hold on the biblio on the OPAC. Notice that when you change the pick up location, the number of days in the pickup message below the dropdown changes based on the circ rules." Not seeing any relevant Javascript errors. I'll look into that next... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #157 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 124568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124568&action=e… Bug 8367: Make database update idempotent -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #156 from David Cook <dcook(a)prosentient.com.au> --- The bug_8367-add_holds_pickup_period_circrule.perl script is not idempotent. It shouldn't re-add the rule on subsequent runs. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8367] How long is a hold waiting for pickup at a more granular level
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '21

07 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #155 from David Cook <dcook(a)prosentient.com.au> --- We're interested in this one too. I might be able to take a look at this one. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 20492] New: Add missing case for advanced search in _fix_limit_special_cases
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '21

06 Sep '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 Bug ID: 20492 Summary: Add missing case for advanced search in _fix_limit_special_cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11