- Koha-bugs - lists.koha-community.org

[Bug 12620] Proxy Add-on for Koha z39.50/SRU servers
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '21

08 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #12 from David Cook <dcook(a)prosentient.com.au> --- Actually for readability we could change 'connect:squid:3128,tcp:lx2.loc.gov:210' to 'connect:squid:3128,lx2.loc.gov:210'. To get this working for Koha... We would need to change our syntax in C4::Breeding::_create_connection to use '$obj->connect($host)' instead of '$obj->connect( $server->{host}, $server->{port} )'. We would also need some way to specify the HTTP Proxy. Option 1: Add a http_proxy field (or http_proxy_hostname and http_proxy_port fields) to the z3950servers table. Option 2: Specify a http_proxy in the koha-conf.xml. This might be a better option, since it's more centralized. Plus, there might be other parts of Koha that would benefit from being able to go through a HTTP proxy. (For example OverDrive integration?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 12620] Proxy Add-on for Koha z39.50/SRU servers
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '21

08 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #11 from David Cook <dcook(a)prosentient.com.au> --- Adam inspired me to test this, and I got a proof-of-concept working in Docker using a Squid proxy. Here are the steps if someone wants to reproduce my efforts: Windows: 1. docker pull sameersbn/squid:3.5.27-2 2. docker run --name squid --publish 3128:3128 sameersbn/squid:3.5.27-2 3. docker cp squid:/etc/squid/squid.conf ./squid.conf.default 4. cp ./squid.conf.default ./squid.conf 5. sed -i 's/http_access deny all/http_access allow all/' ./squid.conf 6. sed -i 's/http_access deny CONNECT/http_access allow CONNECT/' ./squid.conf 7. docker stop squid 8. docker rm squid 9. docker run --name squid --publish 3128:3128 --volume "/$(PWD)/squid.conf:/etc/squid/squid.conf" --net koha_kohanet sameersbn/squid:3.5.27-2 Koha container: 1. http_proxy=squid:3128 curl -v https://www.google.com 2a. yaz-client connect:squid:3128,tcp:lx2.loc.gov:210 2b. base LCDB 2c. find test 2d. show 1 3a. Use ZOOM in a Perl script to connect to Squid proxy 3b. This works (shows 10000 results connecting to LOC LCDB database and searching for as title of ‘test’) 3c. Script included below* * #!/usr/bin/perl use ZOOM; my $conn = new ZOOM::Connection('connect:squid:3128,tcp:lx2.loc.gov:210'); $conn->option( databaseName => 'LCDB' ); my $rs = $conn->search_pqf('@attr 1=4 test'); my $n = $rs->size(); warn $n; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '21

07 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158 --- Comment #13 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Katrin Fischer from comment #12) > The test plan works ok on current master for me, but I assume this is > because the kohadevbox is using ICU by default. I am not sure how to > activate ICU there. I think you mean using CHR by default. I wonder if we should change to ICU default some time. It involves updating /etc/koha/zebradb/etc/default.idx and then re-indexing Zebra. Although I didn't have that in my test plan I wonder why... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12620] Proxy Add-on for Koha z39.50/SRU servers
by bugzilla-daemon＠bugs.koha-community.org 06 Jun '21

06 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12620 --- Comment #10 from David Cook <dcook(a)prosentient.com.au> --- I've heard back from Adam Dickmeiss at Indexdata, and he said "you should be able to use [the connect syntax] for most client software of YAZ". So that's interesting! I'm tempted to do some testing, and build this functionality into Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13307] Create a link to the last advanced search in search result page (OPAC)
by bugzilla-daemon＠bugs.koha-community.org 05 Jun '21

05 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13307 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28518 [Bug 28518] "Return to the last advanced search" exclude keywords if more than 3 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28517] New: Bad encoding in logged-in-branch-name
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '21

04 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28517 Bug ID: 28517 Summary: Bad encoding in logged-in-branch-name Change sponsored?: --- Product: Koha Version: 21.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: resetka.bedi(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 121632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121632&action=e… Staff page with Set library. The problem is in upper right. There was no problem in previous versions. Now, after installing version 21.05, the library name is displayed incorrectly in the upper right (HTML class logged-in-branch-name). It should be correct as it is in the Set library: Bédiho knihovna. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 24855] New: Lost items not marked returned when floating-point math causes amountoutstanding to be not-quite-zero
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '21

04 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24855 Bug ID: 24855 Summary: Lost items not marked returned when floating-point math causes amountoutstanding to be not-quite-zero Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Floating point math and a strict "if amountoutstand=0" result in things not getting marked as returned when they should. I've had a hard time figuring out exactly when this will go wrong, so I've got some very specific steps to recreate. To test: - set MarkLostItemsAsReturned to never mark items returned - turn on Fines log - find/create a patron with no outstanding fees or fines - manually apply 8 overdue charges of $4.10 - create an item with a replacement cost of 6.99 - check item out to patron - mark item lost, generating 6.99 lost fee for patron - pay off entire balance using the Pay Amount button - confirm patron no longer owes any fees, but item has not been marked as returned when fee was paid off - check fines log, see that the accountline for this lost fee recorded a payment of "6.98999999999999" and a new amountoutstanding of "7.105427357601e-15" While we round these values to 4 decimal places in accountlines, that rounding happens *after* Koha checks if amountoutstanding=0 when deciding whether or not to mark the lost item returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 15449] Move stuff to the Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '21

04 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28514 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28514 [Bug 28514] C4::Letters::getletter must be rewritten -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27660] New: Should getletter not use the fallback to default ?
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '21

04 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27660 Bug ID: 27660 Summary: Should getletter not use the fallback to default ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Looking at the code: sub getletter { my ( $module, $code, $branchcode, $message_transport_type, $lang) = @_; .. $lang = 'default' unless( $lang && C4::Context->preference('TranslateNotices') ); .. my $sth = $dbh->prepare(q{ SELECT * FROM letter WHERE module=? AND code=? AND (branchcode = ? OR branchcode = '') AND message_transport_type LIKE ? AND lang =? ORDER BY branchcode DESC LIMIT 1 }); $sth->execute( $module, $code, $branchcode, $message_transport_type, $lang ); my $line = $sth->fetchrow_hashref or return; .. I am just wondering if I miss something. If the language is passed (which is often just a $patron->lang or so), then we are fetching with that language! If that notice has not been translated yet, we will not fallback to en ?! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 14261] Switch 'ask for a discharge' to 'download discharge confirmation' when patron was discharge in OPAC user account
by bugzilla-daemon＠bugs.koha-community.org 04 Jun '21

04 Jun '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14261 --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Katrin Fischer from comment #6) > Would still love some help with fixing my patch! Still looking for someone to help me out here :) -- You are receiving this mail because: You are watching all bug changes.

1 0