- Koha-bugs - lists.koha-community.org

[Bug 27885] Populate biblionumbers parameter when placing hold on single title
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27885 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Nick, from your last comment#, should this be FQA (as in: Needs more work)? You mention an issue with multi-holds for clubs. I doesn't apply, the conflict looks simple, but setting this one step back to get confirmation. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25557] New: Column config table in Acquisitions Order Does not Match the Acq table in Baskets
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25557 Bug ID: 25557 Summary: Column config table in Acquisitions Order Does not Match the Acq table in Baskets Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: lucas(a)bywatersolutions.com Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The actual way that the Acq table appears in the basket view (basket.pl), 1.Basket # 2. Order information 3. RRP Tax Exc 4. Actual Cost Exc 5. Budgeted Cost Tax Exc 6. RRP Tax Included 7. Actual Cost Tax Inc 8. Budgeted Cost Tax Inc 9. Replacement Price 10. Quantity But in the column config table 1.Basket # 2. Order Info 3. RRP tax Exc 4. Ecost Exc (Actual Exc) 5. RRP tax Included 6. Ecost Tax Included (Actual Inc) 7. Replacement Prie 8. Quantity 9. Total Tax Excluded 10. Total Tax Included We will need to change the column configuration to match the table so it is easy to hide the correct columns. -- You are receiving this mail because: You are watching all bug changes.

1 24

[Bug 28310] New: request.pl using biblioitemnumber in biblionumber field
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28310 Bug ID: 28310 Summary: request.pl using biblioitemnumber in biblionumber field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: philippe.blouin(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In reserve/request.pl, the code querying ItemsAnyAvailableAndNotRestricted (previously ItemsAnyAvailableForHold) is passing the biblioitemnumber as a value to a specified biblionumber. ItemsAnyAvailableAndNotRestricted( { biblionumber => $biblioitemnumber, patron => $patron }) All you need is a Koha instance where the values of biblionumber and biblioitemnumber being different for this to break. And break badly. This occurs in 20.05+ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 --- Comment #129 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- (In reply to Joonas Kylmälä from comment #123) > I didn't realize the follow-ups here removed those git merge conflict > resolution hints. It would still probably be better if the conflicts were > solved in the patches they happen. If I review the patch "Test improvements > + check maxreserves" it contains merge resolution and test improvements, so > two things, git commits should do just one thing. Also "Bug 11999: (QA > follow-up)" doesn't say what it does. I've squashed fixes from QA follow-up inside patches. And rebase master. I set back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120778|0 |1 is obsolete| | --- Comment #128 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120780&action=e… Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120776|0 |1 is obsolete| | --- Comment #127 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120779&action=e… Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower Apply the patch 3/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 4/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112874|0 |1 is obsolete| | Attachment #120777|0 |1 is obsolete| | --- Comment #126 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120778&action=e… Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112872|0 |1 is obsolete| | --- Comment #125 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120777&action=e… Bug 11999: Test improvements + check maxreserves improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112871|0 |1 is obsolete| | --- Comment #124 from Fridolin Somers <fridolin.somers(a)biblibre.com> --- Created attachment 120776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120776&action=e… Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower Apply the patch 3/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 4/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 10 May '21

10 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Fridolin Somers <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0