- Koha-bugs - lists.koha-community.org

[Bug 14237] Allow bibs to be added to course without items
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #44 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- I think this patch is the way to go (DBrev) However I am still struggling with something: shouldn't we allow biblionumber xor itemnumber for the different C4::CourseReserves subroutines? It does not make sense to me to pass the biblionumber when we have already the itemnumber. Asking a QA feedback on this question. Kyle or Tomas maybe? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14237] Allow bibs to be added to course without items
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120652|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- Created attachment 120659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120659&action=e… Bug 14237: Set course_items.biblionumber in the DBrev We need to create the new column without the NOT NULL clause, set the correct values, then add the NOT NULL clause. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14237] Allow bibs to be added to course without items
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14237 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #42 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Aleisha Amohia from comment #41) > Created attachment 120652 [details] [review] > Bug 14237: (follow-up) Set course_items.biblionumber for existing rows > > This atomic update will run after the first atomic update which adds the > biblionumber column to course_items. It won't work, the column won't be created because of the NOT NULL clause. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Jonathan Druart <jonathan.druart+koha(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | --- Comment #28 from Jonathan Druart <jonathan.druart+koha(a)gmail.com> --- (In reply to Jonathan Druart from comment #19) > 1. > https://snipboard.io/xZtHsv.jpg > > MariaDB [koha_kohadev]> select ordernumber, estimated_delivery_date from > aqorders; > +-------------+-------------------------+ > | ordernumber | estimated_delivery_date | > +-------------+-------------------------+ > | 7 | NULL | > | 8 | 2021-04-14 | > | 9 | NULL | > | 10 | NULL | > +-------------+-------------------------+ > > If I set a "from" date: > https://snipboard.io/sGRCWS.jpg > > I am expecting to see the same 4 orders. Did you fix that, Aleisha? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 --- Comment #27 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 120656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120656&action=e… Bug 15348: (follow-up) Fix breadcrumbs, title, JS error, permissions -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119299|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 120655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120655&action=e… Bug 15348: trivial code simplification -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119298|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 120654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120654&action=e… Bug 15348: (QA follow-up) Remove superflous filters The QA script highlighted the addition of some unneeded extra TT filters. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119297|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 120653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120653&action=e… Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. The specified estimated delivery date is also considered when searching for late orders and exporting late orders. You can also edit the estimated delivery date from the late orders page. Test plan: 1. Update database, rebuild schema, restart services 2. Go to Acquisitions, search for a vendor, and create a new basket 3. Add an order to the basket. When filling in the accounting details, notice the new 'estimated delivery date' field, but don't add a date. Save the order. 4. Confirm no date shows in the estimated delivery date column in the orders table. 5. Modify the order. Add a date in the estimated delivery date field and save the order. 6. Confirm the date now shows in the orders table. 7. Close the basket. 8. Go to the Late Orders page. 9. Put estimated delivery date from and to parameters in the search filters on the left. Ensure the from and to dates encapsulate the date you entered in the estimated delivery date field for the order. 10. Click Filter and ensure the order shows. 11. Select the checkbox next to the order. Click the Export as CSV button. 12. Open the CSV and confirm the estimated delivery date that you entered shows as expected in the file. 13. Click Edit under the estimated delivery date. Confirm the estimated delivery date modal pops up with the correct order line number in the modal header. 14. Remove the estimated delivery date and click Save. 15. Confirm that the estimated delivery date calculated by Koha now shows in the late orders table. 16. Select the checkbox next to the order. Click the Export as CSV button. 17. Open the CSV and confirm the calculated estimated delivery date shows in the CSV. 18. Confirm tests pass: t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15348] Change/Edit estimated delivery date per order line
by bugzilla-daemon＠bugs.koha-community.org 07 May '21

07 May '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0