- Koha-bugs - lists.koha-community.org

[Bug 13613] Don't allow digest to be selected without a digest-able transport selected
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13613 --- Comment #13 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 120081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120081&action=e… Bug 13613: (follow-up) Add tooltip when disabled This patch adds a tooltip to the digest checkboxes when disabled. When enabled the tooltip is hidden -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28174] New: Add ability to limit item modification to current library
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28174 Bug ID: 28174 Summary: Add ability to limit item modification to current library Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Before we can deprecate IndependantBranches and use Library Groups as a replacement, we need the ability to limit item modifications to only those items belonging to the branch/branches the librarian has permissions/access to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 12362] Branch transfer records orphaned on cancelled holds
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 --- Comment #29 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12362] Branch transfer records orphaned on cancelled holds
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12362] Branch transfer records orphaned on cancelled holds
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 --- Comment #28 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #27) > Adjusted DBrev to not lose ItemLost from bug 27281. Scratch that. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12362] Branch transfer records orphaned on cancelled holds
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Adjusted DBrev to not lose ItemLost from bug 27281. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12362] Branch transfer records orphaned on cancelled holds
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #25) > It may be something we fixed with bug 23129 (Confirmed) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21754] New: If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21754 Bug ID: 21754 Summary: If an item is marked as lost, any outstanding transfers upon it should be automatically cancelled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: alexbuckley(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When an item is marked as lost automatically cancel any outstanding transfers on it (this is an alternative to bug 21732 - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21732- which checks if a syspref is enabled before cancelling outstanding transfers on the lost item). Also set the items holding branch to the transfers source ('from') branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 12362] Branch transfer records orphaned on cancelled holds
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21754, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23129 --- Comment #25 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Putting down some investigations: Commit 66f1605c59763613a4e955fd259a845e4fc06324 (bug 21754) introduces the ModItem call to adjust holdingbranch, and the tests. If we checkout this commit and comment the ModItem call, the tests fail with: # Failed test 'Lost item with cancelled hold has holding branch equallying the transfers source branch' # at t/db_dependent/Circulation.t line 2481. # got: 'e9cN2ZmqsE' # expected: 'OIL0DThSY1' It proves that the test is correct. However, on master (f096a8dffc), the tests still pass if we comment the current line: Koha::Items->find($itemnumber)->holdingbranch($frombranch)->store({ skip_record_index => $params->{skip_record_index} }); It may be something we fixed with bug 23129, which patched in ModItemTransfer, but if we look at the code there are conditionals to reach ModItemTransfer. Trusting Martin, Kyle and Nick as I don't have more time to investigate this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23129] New: Items holdingbranch should be set to the originating library when generating a transfer
by bugzilla-daemon＠bugs.koha-community.org 23 Apr '21

23 Apr '21

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23129 Bug ID: 23129 Summary: Items holdingbranch should be set to the originating library when generating a transfer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- In C4::Items::ModItemTransfer we call ModItem to update the holdingbranch of the item. Currently we set this to the transfer destination. By definition we are generating a transfer because the item has not yet arrived. We should set the holdingbranch to the current location of the item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 43