- Koha-bugs - lists.koha-community.org

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #30) > I've made some starting changes to the notices to use Koha::Biblio objects > mostly (you can see it in the atomic update in the patch). > > I need some guidance/help with a few things: > - I wasn't sure where to get the dewey and classification info from It looks like they are always empty. It's broken since the following commit: commit af466ca41ab02150f4f6c60bf6262b079b2e6e85 Date: Thu Oct 18 18:53:52 2007 -0500 start of reworking call number handling and other Biblio changes IMO we should not reintroduce them on this bug report. > - I wasn't sure which notes field to use (biblioitems or biblio) It's coming GetBiblioData 729 my $query = " SELECT * , biblioitems.notes AS bnotes, itemtypes.notforloan as bi_notforloan, biblio.notes So it's the 'notes' from biblio. > - the Author and Subjects subroutines are the hardest for me to refactor > because I'm not sure how different libraries use them Hum... Another weirdness. On opac-sendshelf: MARCSUBJCTS is set but not used in the template, 'subject' is used instead, but never sent from the pl... and it's the same for the other ones (sendbasket, sendshelf both OPAC and staff interfaces). I'd drop it as well. For MARCAUTHORS I'd try and write the equivalent of C4::Biblio::GetMarcAuthors in TT, and see how it goes (10 lines or 30 lines?). If it's too ugly then move to Koha::Biblio->get_MARC_authors (or get_authors_from_MARC?) > Some feedback would be great! Don't forget that you are in a quite dirty place. Don't loose time with things that are not working, drop them. I'd suggest that you focus on the simplest template first, no need to work in parallel on the four ones. Additional note, in your patch you are not looping at all on a Koha::Biblio set. As it's a WIP maybe you are aware of it, but I prefer to highlight it in case you missed it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 18789] New: Send a Koha::Patron object to the templates
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Bug ID: 18789 Summary: Send a Koha::Patron object to the templates Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 18403 The simplify and make uniform the code, the controller scripts should send a Koha::Patron object to the templates and not all attributes of a patron. That will make the code much more easier to maintain and will be less error-prone. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes.

1 112

[Bug 14564] Incorrect permissions prevent web download of configuration backups
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14564] Incorrect permissions prevent web download of configuration backups
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #30 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- I've made some starting changes to the notices to use Koha::Biblio objects mostly (you can see it in the atomic update in the patch). I need some guidance/help with a few things: - I wasn't sure where to get the dewey and classification info from - I wasn't sure which notes field to use (biblioitems or biblio) - the Author and Subjects subroutines are the hardest for me to refactor because I'm not sure how different libraries use them Some feedback would be great! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 21 Dec '20

21 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114127|0 |1 is obsolete| | --- Comment #29 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 114545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114545&action=e… Bug 3150: WIP -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '20

20 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #28 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- In my opinion, we should pass Koha::Object(s) to the template as much as possible. It will be much easier to document the things that are available for rendering, as opposed to the current situation, on which it is not straight forward to know what is available in which context. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '20

20 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #27 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Ah I see what you're both saying. i'll give that a go -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3150] Move emails for sending cart and list contents into notices tool
by bugzilla-daemon＠bugs.koha-community.org 20 Dec '20

20 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27268 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace -- You are receiving this mail because: You are watching all bug changes.

1 0