- Koha-bugs - lists.koha-community.org

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #70 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 114132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114132&action=e… Bug 12430: Add unit tests for C4::Search::buildQuery This patch adds unit tests for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114129|0 |1 is obsolete| | --- Comment #69 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 114131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114131&action=e… Bug 12430: Use releance ranking without QueryWeightFields The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto 2) Turn off "UseQueryParser" 3) Do a keyword search in the OPAC 4) Note that the results are ordered by biblionumber ascending 5) Apply patch 6) Do the same keyword search in the OPAC 7) Note that the results are never ordered differently (presumably in relevance order :P) If you're a stickler, throw in some warns so that you can see what CCL query is being sent to Zebra. Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #68 from David Cook <dcook(a)prosentient.com.au> --- Very old style commit message name. I might just fix that up now... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #67 from David Cook <dcook(a)prosentient.com.au> --- When this is pushed, I'm half tempted to push for a removal of "QueryWeightFields" completely as I reckon it causes more grief than it's worth... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #66 from David Cook <dcook(a)prosentient.com.au> --- To run the unit tests: root@kohadevbox:koha(bug_12430)$ prove t/Search/buildQuery.t t/Search/buildQuery.t .. ok All tests successful. Files=1, Tests=10, 3 wallclock secs ( 0.03 usr 0.01 sys + 2.87 cusr 0.15 csys = 3.06 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99158|0 |1 is obsolete| | --- Comment #65 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 114130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114130&action=e… Unit tests for buildQuery This patch adds unit tests for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99141|0 |1 is obsolete| | --- Comment #64 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 114129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114129&action=e… Bug 12430: Force relevance ranking when not using QueryParser The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 0) Use koha-testing-docker 1) Ensure that "QueryWeightFields" is enabled and "QueryAutoTruncate" is set to auto 2) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?q=e 3) Note that the results are ordered by biblionumber ascending 4) Apply patch 5) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?q=e 6) Note that the results are not ordered by biblionumber ascending (presumably they are in relevance order) If you edit /etc/koha/sites/kohadev/koha-conf.xml and add "requests" to the end of "zebra_loglevels", uncomment that option, and carefully restart Zebra, you should be able to see the following in /var/log/koha/kohadev/zebra-output.log: Search biblios OK 394 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 @attr 2=102 e The 2=102 indicates a relevance search. Signed-off-by: Victor Grousset/tuxayo <victor(a)tuxayo.net> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #63 from David Cook <dcook(a)prosentient.com.au> --- Changing the 2nd patch to use t/Search/buildQuery.t instead of t/Search.t because it's so complex it deserves to be in its own file... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12430] Search truncation disables relevance ranking
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '20

03 Dec '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #62 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Nind from comment #51) > Everything works as per the the test plan, but tests fail: > > Test Summary Report > ------------------- > t/Search.t (Wstat: 256 Tests: 6 Failed: 1) > Failed test: 5 > Non-zero exit status: 1 > Files=1, Tests=6, 4 wallclock secs ( 0.03 usr 0.01 sys + 3.42 cusr 0.12 > csys = 3.58 CPU) > Result: FAIL It looks like the first patch is good, but my "Unit tests for buildQuery" patch is not. -- You are receiving this mail because: You are watching all bug changes.

1 0