- Koha-bugs - lists.koha-community.org

[Bug 16696] Rename "Publisher" on detail and result lists
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16696 --- Comment #13 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 113125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113125&action=e… Bug 16696: Fix search_utf8.t -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #46 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 113121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113121&action=e… Bug 14708: (QA follow-up) Add tests This patch adds tests for the change. It also simplifies the delete() method structure a bit. It fixes the error 500 the tests were raising. To test: 1. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => FAIL: Tests fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! The new behaviour (code 403) is tested! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #45 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #43) > There is a test failing however: > > # Failed test 'Patron not found' > # at t/db_dependent/api/v1/patrons.t line 423. > # got: '500' > # expected: '404' > > > And a test missing to cover the change from the last patch. BTW: I love tests :-D -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8753] Add forgot password link to OPAC
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26941 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 [Bug 26941] Missing OPAC password recovery error messages -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #44 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #42) > Having this code into master won't help anything: it will have to be rebuilt > as it cannot be used as a good base. > > I am willing to push this patchset as it, given the low bug number (but not > sure it's a good argument...) The argument is, this is a bugfix. And refactoring things the way they are discussing is a good path forward. But it won't happen in stable for a while. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- There is a test failing however: # Failed test 'Patron not found' # at t/db_dependent/api/v1/patrons.t line 423. # got: '500' # expected: '404' And a test missing to cover the change from the last patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14708] The patron set as the anonymous patron should not be deletable
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Having this code into master won't help anything: it will have to be rebuilt as it cannot be used as a good base. I am willing to push this patchset as it, given the low bug number (but not sure it's a good argument...) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26938 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 [Bug 26938] Prevent flash of unstyled content on sales table -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 05 Nov '20

05 Nov '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26939 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 [Bug 26939] Account payment_type in the cash register details page should use description instead of code. -- You are receiving this mail because: You are watching all bug changes.

1 0