- Koha-bugs - lists.koha-community.org

[Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 --- Comment #18 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Nick Clemens from comment #17) > I was unsure at first about not being able to add a reason without sending > the notice, however, it seems like you just won't add a reason if you don't > want to send. > > You can also force the reason and prevent sending by wrapping the notice in > a conditional: > [% UNLESS hold.cancellation_reason == 'INSANITY' %] > ... > [% END %] Totally agree, at first o felt it a bit odd you couldn't add a reason without sending the notice but I came to the same conclusion regarding doing it at the TT template conditional level. I think if we wanted a nicer way to allow addition of a reason without triggering the notice we should do that as its own bug as we're just using the logic introduced in the dependancy bug here. Thanks for the testing and QA everyone. 😀 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8437] Large database backups and large exports from export.pl fail under plack
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |nick(a)bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com --- Comment #17 from Nick Clemens <nick(a)bywatersolutions.com> --- I was unsure at first about not being able to add a reason without sending the notice, however, it seems like you just won't add a reason if you don't want to send. You can also force the reason and prevent sending by wrapping the notice in a conditional: [% UNLESS hold.cancellation_reason == 'INSANITY' %] ... [% END %] -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112337|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 112350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112350&action=e… Bug 12656: Allow --reason to be passed to cancel_expired_holds This patch adds the --reason option to cancel_expired_holds which allows the library to optionally set a reason for cancellation when running the cronjob. This will prompt the HOLD_CANCELLED notice to be sent to the patron. To test: 1/ Ensure the unit tests continue to pass after the patch (t/db_dependent/Reserves/CancelExpiredReserves.t) Also: 1 - Add an expired hold for a patron: INSERT INTO RESERVES (borrowernumber, biblionumber, expirationdate, found,branchcode,itemnumber) VALUES (5,5,'2020-01-01','W','CPL',983); 2 - Set ExpireReservesMaxPickUpDelay to Allow 3 - Run the cronjob: perl misc/cronjobs/hold/cancel_expired_holds.pl --reason EXPIRED 4 - Visit the patron's notices tab 5 - Confirm they have been sent a cancellation notice Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 23796] New: Convert OpacCustomSearch system preference to news block
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23796 Bug ID: 23796 Summary: Convert OpacCustomSearch system preference to news block Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Depends on: 22318 Building on 22318, the OpacCustomSearch system preference should be converted to a Koha news block. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112200|0 |1 is obsolete| | --- Comment #15 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Created attachment 112337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112337&action=e… Attachment to Bug 12656 - Send a notice to patrons when their hold was cancelled because it was not picked up Bug 12656: Allow --reason to be passed to cancel_expired_holds This patch adds the --reason option to cancel_expired_holds which allows the library to optionally set a reason for cancellation when running the cronjob. This will prompt the HOLD_CANCELLED notice to be sent to the patron. To test: 1/ Ensure the unit tests continue to pass after the patch (t/db_dependent/Reserves/CancelExpiredReserves.t) Signed-off-by: Lisette Scheer <lisettes(a)latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8137] Checkout limit by patron category for all libraries
by bugzilla-daemon＠bugs.koha-community.org 24 Oct '20

24 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #55 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Applying: Bug 8137: Add Default checkout limit by patron category with priority. Applying: Bug 8137: Add default issuing rule for all branches. error: sha1 information is lacking or useless (admin/smart-rules.pl). error: could not build fake ancestor Patch failed at 0001 Bug 8137: Add default issuing rule for all branches. The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-8137-Add-default-issuing-rule-for-all-branches-zg277r.patch -- You are receiving this mail because: You are watching all bug changes.

1 0