- Koha-bugs - lists.koha-community.org

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #62 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- (In reply to Martin Renvoize from comment #60) > However, sorry Joonas, but t/db_dependent/api/v1/holds.t is failing.. and > ideally I'd love to see some basic tests for the new set_* methods > introduced in Koha::Hold. They're trivial methods, but having a unit test > that proves they correctly set the three fields for each of the methods will > help prevent future regressions. thanks, fixed the api test. I added the same test to set_processing and set_transfer methods by calling $hold->suspend_hold as there was originally with the set_waiting method. That should check what the function already does (just set the found status). Do you think it is still required to explicitly check the found status for these (even though it indirectly is checked by suspend_hold call)? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #61 from Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> --- Created attachment 111509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111509&action=e… Bug 12556: (follow-up) Fix failing test The method call set_waiting(1) was renamed to be set_transfer() -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #60 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Looks good :) However, sorry Joonas, but t/db_dependent/api/v1/holds.t is failing.. and ideally I'd love to see some basic tests for the new set_* methods introduced in Koha::Hold. They're trivial methods, but having a unit test that proves they correctly set the three fields for each of the methods will help prevent future regressions. Failing QA, but hopefully not for long. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #59 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 111500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111500&action=e… Bug 12556: (QA follow-up) Fix QA Script failures Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111410|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 111499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111499&action=e… Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item <ItemBarcode> -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron <PatronABarcode> --item <ItemBarcode> -m checkout Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass(a)ub.lu.se> Rebased-by: Joonas Kylmälä <joonas.kylmala(a)helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111409|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 111498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111498&action=e… Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass(a)ub.lu.se> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111408|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 111497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111497&action=e… Bug 12556: reserves/request.pl: Reuse code from Koha::Hold Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass(a)ub.lu.se> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111407|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 111496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111496&action=e… Bug 12556: Reuse code from Koha::Hold instead of duplicating it Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass(a)ub.lu.se> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111406|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 111495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111495&action=e… Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass(a)ub.lu.se> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '20

12 Oct '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111405|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 111494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111494&action=e… Bug 12556: Refactor hold transfer status setting to its own method Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass(a)ub.lu.se> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0