- Koha-bugs - lists.koha-community.org

[Bug 25608] New: Regression: Bug 23463 broke inventory
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25608 Bug ID: 25608 Summary: Regression: Bug 23463 broke inventory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: didier.gautheron(a)biblibre.com Reporter: didier.gautheron(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 23463 need to use unblessed items. Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Check ' - Submit => without patch, you get an error trace Error trace Can't call method "title" on an undefined value at /kohadevbox/koha/tools/inventory.pl line 347, <$fh> line 2. at /kohadevbox/koha/tools/inventory.pl line 347 in (eval) at /kohadevbox/koha/tools/inventory.pl line 347 344: : $inventorylist // []; 345: for my $item ( @$loop ) { 346: my $biblio = Koha::Biblios->find( $item->{biblionumber} ); 347: $item->{title} = $biblio->title; 348: $item->{author} = $biblio->author; 349: } 350: Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes.

1 14

[Bug 25556] New: Holds blocked when empty holdallowed value present in circulation_rules
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25556 Bug ID: 25556 Summary: Holds blocked when empty holdallowed value present in circulation_rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: stalkernoid(a)gmail.com Reporter: nugged(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, slavashishkin(a)gmail.com Holds blocked ("Cannot place hold" yellow notification window) for default rule after onboarding.pl (web installation process). That happens because /cgi-bin/koha/installer/onboarding.pl script creates the empty (holdallowed="") key/value pair in the circulation_rules table. Probably empty ("") holdallowed key assumed to have the same behavior as undef/NULL, because: - in the interface (/cgi-bin/koha/admin/smart-rules.pl) both are interpreted as "Not set" (undef or ""), - if to remove this empty value for holdallowed from circulation_rules table at all (so have it undef) holds allowed and not blocked. - in other cases if "holdallowed" has correct values from the dropdown list (0, 1, 2, 3) - all works as expected. I.e.: 1. ="" has behavior as ="0", 2. value absence (NULL/undef) has behavior as ="2" ("from any library"). 3. but for both values site interface shows "not set". This makes confusion: in 1. it blocks holds, and in 2. it allows. I propose we make both "" and undef work similarly as "not set" in "check if holds allowed" code, and both to allow holds like undef now does. And at the same time remove "" creation but use undef instead in the onboarding process when done first rule creation. -- You are receiving this mail because: You are watching all bug changes.

1 26

[Bug 25428] New: Escaped HTML shows in authority detail view when subfield is a link
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25428 Bug ID: 25428 Summary: Escaped HTML shows in authority detail view when subfield is a link Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Created attachment 104604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104604&action=e… Screenshot showing the problem In authority records there is the option to designate a subfield as a URL (like we do for 856$u in the default MARC framework). When you view the details of such a record the URL is output to the screen as HTML markup. This is because the script is sending hard-coded HTML to the template and the template outputs is as escaped. Rather than use the $raw filter to make the link work, we should remove the script-generated HTML and do it in the template. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 11

[Bug 25452] New: Alternate email contact not displayed
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25452 Bug ID: 25452 Summary: Alternate email contact not displayed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Patrons Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The B_email field of a patron is not display on the moremember page (patron view) -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 25721] New: Club enrollment notification
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25721 Bug ID: 25721 Summary: Club enrollment notification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Would like to see a club enrollment notification. Would like a field that can be setup in the club for who to notify (e-mail or e-mails separated by a comma or whatever), and then they would be notified when someone signs up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 25720] New: Add the ability to send an e-mail or notifications to a particular club
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25720 Bug ID: 25720 Summary: Add the ability to send an e-mail or notifications to a particular club Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Would like to see a way of e-mailing/sending a print notice to those enrolled in a particular club. I could see a new action added to the club called Contact, and you could fill out a text field with your message, and there would be an option to add the patron's name, info from club fields, etc... similar to create a notice, but simpler for front line staff. Once done, you could preview, and it would show a screen with the first member's info filled out, and you could advance through the members to preview if you like, or if you are satisfied, send the e-mail to those members. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 25563] New: Cannot sub "add order from MARC file" form after alert
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25563 Bug ID: 25563 Summary: Cannot sub "add order from MARC file" form after alert Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 24386 If you get an alert about "no fund selected" you won't be able to submit the form. To recreate (test plan from bug 25473) - stage a marc record - acquisitions: have a basket - click on "Add to basket" - "From a staged file" - Don't tick the record - Save - You should see an expected error message - Tick the record - Choose a fund - Save (at least try) - Nothing happens :< Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24386 [Bug 24386] Double submit should be prevented when adding to a basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 24881] New: Circulation.t still fails if tests are ran slowly
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24881 Bug ID: 24881 Summary: Circulation.t still fails if tests are ran slowly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 22917 Bug 22917 - Circulation.t fails if tests are ran slowly Not fixed, or regression added after. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22917 [Bug 22917] Circulation.t fails if tests are ran slowly -- You are receiving this mail because: You are watching all bug changes.

1 42

[Bug 24062] New: Circulation tests fail randomly if patron category type is 'X'
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Bug ID: 24062 Summary: Circulation tests fail randomly if patron category type is 'X' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org The items are not issued if the patron category's type is 'X', used for statistics. koha_1 | # Failed test 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' koha_1 | # at t/db_dependent/Circulation.t line 1994. koha_1 | # got: undef koha_1 | # expected: '1' koha_1 | # Looks like you planned 2 tests but ran 1. koha_1 | # Looks like you failed 1 test of 1 run. koha_1 | koha_1 | # Failed test 'CanBookBeIssued + AutoReturnCheckedOutItems' koha_1 | # at t/db_dependent/Circulation.t line 2001. koha_1 | Can't call method "borrowernumber" on an undefined value at t/db_dependent/Circulation.t line 1998. -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 25531] New: Patron may not be debarred if backdated return
by bugzilla-daemon＠bugs.koha-community.org 11 Jun '20

11 Jun '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25531 Bug ID: 25531 Summary: Patron may not be debarred if backdated return Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Circulation Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com This has been caught by a test failing randomly: 15:41:14 koha_1 | # Failed test 'AddReturn must have debarred the patron' 15:41:14 koha_1 | # at t/db_dependent/Circulation.t line 88. 15:41:14 koha_1 | # got: '' 15:41:14 koha_1 | # expected: '1' 15:41:14 koha_1 | # AddReturn returned message $VAR1 = { 15:41:14 koha_1 | # 'WasReturned' => 1 15:41:14 koha_1 | # }; 15:41:14 koha_1 | 15:41:14 koha_1 | # Failed test 'Test at line 2282' 15:41:14 koha_1 | # at t/db_dependent/Circulation.t line 92. 15:41:14 koha_1 | # got: '0' 15:41:14 koha_1 | # expected: '1' 15:41:14 koha_1 | 15:41:14 koha_1 | # Failed test 'Test at line 2282' 15:41:14 koha_1 | # at t/db_dependent/Circulation.t line 95. 15:41:14 koha_1 | # got: undef 15:41:14 koha_1 | # expected: '2020-06-01' 15:41:14 koha_1 | # Looks like you failed 3 tests of 21. 15:41:14 koha_1 | 15:41:14 koha_1 | # Failed test 'AddReturn + suspension_chargeperiod' 15:41:14 koha_1 | # at t/db_dependent/Circulation.t line 2291. 15:41:28 koha_1 | # Looks like you failed 1 test of 48. 15:41:28 koha_1 | [13:41:28] t/db_dependent/Circulation.t To know if an issue is overdue, we compared it with today. But we should compare it with the return date is provided -- You are receiving this mail because: You are watching all bug changes.

1 25