- Koha-bugs - lists.koha-community.org

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #99 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #90) I then decided to remove the specific logging output, we could deal with it correctly on a separate bug report. Patches rebased and PQA. If this is pushed to 20.05 we will need to make sure the log files' permissions are correct when the debian packages are used, and that the different scripts that use Koha::Logger works properly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #98 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104674&action=e… Bug 15253: Remove specific logging output * We should not call Log::Log4perl directly * Not sure it is correct as I get from (comment 77): % koha-sip --restart [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm line 42. C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) Why "ERROR" when it's a warning? The [undef]@[undef] seems wrong here. Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #97 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104673&action=e… Bug 15253: Add POD to C4/SIP/Logger.pm and C4/SIP/Trapper.pm Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #96 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104672&action=e… Bug 15253: Convert all tabs into 4 spaces in affected files Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #95 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104671&action=e… Bug 15253: Log trapped errors as log level 'warn' instead of 'error' Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #94 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104670&action=e… Bug 15253: Add log4perl conf updates for Debian packages * Add log4perl conf updates for Debian packages * Rename sip2.log to sip.log Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #93 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104669&action=e… Bug 15253: Rename syslog() to siplog() Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #92 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104668&action=e… Bug 15253: Move subs to a new module, allow unit tests to function Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103915|0 |1 is obsolete| | Attachment #103916|0 |1 is obsolete| | Attachment #103917|0 |1 is obsolete| | Attachment #103918|0 |1 is obsolete| | Attachment #103919|0 |1 is obsolete| | Attachment #103920|0 |1 is obsolete| | Attachment #103921|0 |1 is obsolete| | Attachment #104016|0 |1 is obsolete| | --- Comment #91 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104667&action=e… Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 11 May '20

11 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0