- Koha-bugs - lists.koha-community.org

[Bug 25419] New: Jsjd
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25419 Bug ID: 25419 Summary: Jsjd Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: skylarkskyzee(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Created attachment 104524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104524&action=e… Hahha HACKED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy(a)bywatersolutions.com --- Comment #10 from Joy Nelson <joy(a)bywatersolutions.com> --- does not apply to 19.11.x branch. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24715] New: Cache repeatable subfield in TransformKohaToMarc
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24715 Bug ID: 24715 Summary: Cache repeatable subfield in TransformKohaToMarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org Follow-up of bug 21800 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 33

[Bug 24840] New: Datetime issues in automatic_renewals / CanBookBeReserved
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24840 Bug ID: 24840 Summary: Datetime issues in automatic_renewals / CanBookBeReserved Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com I cannot recreate this, however, we have sites that experience automatic_renewals.pl crashing with: Invalid local time for date in time zone: America/New_York It seems to happen around the daylight savings change There is: DateTime->now( time_zone => C4::Context->tz() ) In C4::Circulation::CanBookBeRenewed but I can't purposely make that fail -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 18

[Bug 8326] Allow patron attributes to be made repeatable after initial creation
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs(a)lists.koha-commun |jonathan.druart(a)bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8326] Allow patron attributes to be made repeatable after initial creation
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 --- Comment #2 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 104517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104517&action=e… Bug 8326: Make repeatable and unique_id modifiable when editing patron attribute type This patch add the ability to modify the attribute "repeatable" and "unique_id" for a patron's attribute type. Prior to this patch it was not possible, to keep data integrity. When editing an attr type, the controller will check is the value can be modified, depending on the existing patron's attributes. Test plan: 0/ Setup Create 1 patron attribute PA1 that can be repeatable Create 1 patron attribute PA2 that does not have the unique restriction Create 1 patron attribute PA3 that does not have such restrictions 1/ Edit them and confirm that you can modify the repeatable and unique restrictions 2/ Restore values from 0. Create a patron P1 with several PA1, PA2=42 and whatever in PA3 3/ Edit PA1 => you cannot remove the repeatable flag but can still remove the unique 4/ Create a patron P2 with PA2=42 5/ Edit PA2 => you cannot remove the unique flag Play a bit more with the different combinaisons and confirm that it works as advertised. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8326] Allow patron attributes to be made repeatable after initial creation
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #90 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #89) > (In reply to Kyle M Hall from comment #87) > > (In reply to Jonathan Druart from comment #77) > > > % koha-sip --restart > > > > > > and I get: > > > > > > [2020/04/23 11:23:27] [ERROR] [undef]@[undef]: Argument "0.33_01" isn't > > > numeric in numeric lt (<) at /usr/share/perl5/Net/Server/Log/Sys/Syslog.pm > > > line 42. > > > C4::SIP::Trapper::PRINT /kohadevbox/koha/C4/SIP/Trapper.pm (24) > > > > > > > > > Why "ERROR" when it's a warning? > > > The [undef]@[undef] seems wrong here. > > > > During normal SIP use, that will show the sip account used and the incoming > > ip address. For unit tests and such they appear as undefs. > > I was missing that they were variables defined in SIPServer.pm: > > + # Flush previous MDCs to prevent accidentally leaking incorrect > MDC-entries > + Log::Log4perl::MDC->put( "accountid", undef ); > + Log::Log4perl::MDC->put( "peeraddr", undef ); > > Is that correct to use directly Log::Log4perl here? Should not it be a > Koha::Logger method instead? I see little benefit in using Koha::Logger directly here, it would just add another layer of abstraction. However, I wouldn't be opposed either. It makes more sense to prevent scope creep here and make that encapsulation part of a future bug report. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 25415] New: Suggestion for a good POD format
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25415 Bug ID: 25415 Summary: Suggestion for a good POD format Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Search in the state of the art for what's best to use for POD (parameter, return values, etc.) Look at other Perl projects: Mojolicious, DBIx::Class, etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 25414] New: head2 POD inconsistent in Koha namespace
by bugzilla-daemon＠bugs.koha-community.org 07 May '20

07 May '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25414 Bug ID: 25414 Summary: head2 POD inconsistent in Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org There are: =head2 Class Methods =head2 Internal Methods TODO: * Remove unnecessary uppercase on "Methods" * Class methods is not correct in most of the case, a class method is a method that must be called on the class, not an instance. We should rename it "Instance methods" * Reposition the =head2 correctly (sometimes internal methods are in "Class methods" and vice versa) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2