- Koha-bugs - lists.koha-community.org

[Bug 8132] Batch delete tool deletes items with holds on them
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #66 from Victor Grousset/tuxayo <victor(a)tuxayo.net> --- > "Has been effective", so you should be on the next screen, not the confirmation screen. Okay, indeed after confirmation the deletion works. >> I guess that's not an issue. But I still have a item I can't delete. > If the reason makes sense, yes it's expected. That's the point of the patchset. Indeed, the item-level hold is the cause. >From what I understand, no issue found, so I will sign it off. Later in the day I think. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103144|Bug 24487: Add 2 more tests |[19.11.x] Bug 24487: Add 2 description| |more tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103143|Bug 24487: Don't apply |[19.11.x] Bug 24487: Don't description|matching criteria to path |apply matching criteria to |parameters |path parameters -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103142|Bug 24487: Regresion test |[19.11.x] Bug 24487: description| |Regresion test -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98165|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Attachment #98166|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98166|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103144&action=e… Bug 24487: Add 2 more tests And make sure tests pass if there is no patron with borrowernumber=10 in DB. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Ammended test description Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98165|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103143&action=e… Bug 24487: Don't apply matching criteria to path parameters This patch separates query parameters from path parameters, and uses exact matching for the later. To test: 1. Apply this patch 2. prove t/Koha/REST/Plugin/Query.t t/db_dependent/Koha/REST/Plugin/Objects.t SUCCESS => tests ok 3. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24487] build_query_params helper builds path parameter with matching criteria
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24487 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103105|0 |1 is obsolete| | Attachment #103106|0 |1 is obsolete| | Attachment #103107|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 103142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103142&action=e… Bug 24487: Regresion test This patch introduces a regresion test where a path parameter is combined with 'contains' match criteria To test: 1. apply this patch 2. prove t/db_dependent/Koha/REST/Plugin/Objects.t Test should fail at this point. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '20

17 Apr '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0