- Koha-bugs - lists.koha-community.org

[Bug 24602] New: The fallback value for onshelfholds should be 0
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24602 Bug ID: 24602 Summary: The fallback value for onshelfholds should be 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The onshelfholds circulation rules values are more of an ENUM type (as opposed to other rules with integers like max*qty). In the quantities cases, it makes sense to have undef mean unlimited. In the enum type it is clearer to just set a default value (0) as the code already expects (Note: undef and 0 both eval to false so there's no behaviour problem, but warnings or we get forced to check for defined when the rule is used. It seems trivial to just make the rule fallback to a chosen default value) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 15

[Bug 13420] Holdings table sorting on volume information incorrect
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '20

05 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.04 released in| | CC| |joy(a)bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #30 from Joy Nelson <joy(a)bywatersolutions.com> --- Pushed to 19.11.x for 19.11.04 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24795] Password change at first login
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24795 George Williams (NEKLS) <george(a)nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george(a)nekls.org --- Comment #1 from George Williams (NEKLS) <george(a)nekls.org> --- This is a really good idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13985] Cash Management - Koha as 'Point of Sale'
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790 [Bug 24790] POS missing from the 'More' dropdown -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790 [Bug 24790] POS missing from the 'More' dropdown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 13945] Multiple dialogs for item that needs transferred and hold captured at checkin
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13945 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24790 [Bug 24790] POS missing from the 'More' dropdown -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #59 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #57) > + [%- IF ( patron.get_age ) %] ([% patron.get_age | html %] years) > + [%- ELSIF ( patron.age ) %] ([% patron.age | html %] years)[% END > -%] > > That smells. > You should either test for the type of patron, or pass another variable > patron_object vs patron > or > patron vs borrower (that reads wrong but it is what is usually done in > controllers) Sorry, I was reading the patch and not the final change. I added a follow-up. However I still think it's lot of info that could be considered not needed by some. Especially in the circ autocomplete. Letting someone else adding the QA stamp. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 --- Comment #50 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- This generally seems to work.. but I'm no SIP expert and the code is hard to follow at the best of times. I would love to see the actually logging statements look more like elsewhere in Koha... this will be the third form for calling a Koha::Logger based log and is more confusing by the fact it keeps the 'syslog' name so if someone is keen to add more statements they may go looking for Sys::Syslog documentation and get mislead. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #58 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 100118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100118&action=e… Bug 15400: Clarify usage of patron-age.inc -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '20

04 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #57 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- + [%- IF ( patron.get_age ) %] ([% patron.get_age | html %] years) + [%- ELSIF ( patron.age ) %] ([% patron.age | html %] years)[% END -%] That smells. You should either test for the type of patron, or pass another variable patron_object vs patron or patron vs borrower (that reads wrong but it is what is usually done in controllers) -- You are receiving this mail because: You are watching all bug changes.

1 0