- Koha-bugs - lists.koha-community.org

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91593|0 |1 is obsolete| | --- Comment #97 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 99928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99928&action=ed… Bug 11999: Test improvements improve t/db_dependent/Reserves.t to make tests pass on UNIMARC installation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Arthur Suzuki <arthur.suzuki(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91581|0 |1 is obsolete| | Attachment #91591|0 |1 is obsolete| | --- Comment #96 from Arthur Suzuki <arthur.suzuki(a)biblibre.com> --- Created attachment 99927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99927&action=ed… Bug 11999: Add maxreserves check in CanBookBeReserved and CanItemBeReserved - Check if borrower has reached the maximum number of holds allowed (syspref maxreserves) The goal of this patch is to do these checks also when using ILS-DI services HoldTitle and HoldItem Test plan: ---------- Before patch: 1/ Set syspref maxreserves to 1 2/ Place some holds through ILS-DI and note that you can place more than 1 hold for a borrower Apply the patch 3/ Place some holds through ILS-DI, you shouldn't be able to place more than 1 hold for a borrower 4/ Try to place holds on staff interface and OPAC. The behaviour must be identical than before the patch. Maxreserves and alreadyreserved works on ILSDI Maxreserves works also on staff and opac Already reserves works also on staff and opac tests on t/db_dependent/Reserves.t and t/db_dependent/Holds.t passe (using koha_ut db) Signed-off-by: Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> Signed-off-by: Alex Arnaud <alex.arnaud(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #57 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Followups coming.. this has turned into a todo list for myself to help get this past the line. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #56 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- It also requires 'OpacKohaUrl' to be enabled.. that feels like an error. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #55 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Jonathan Druart from comment #49) > (In reply to Katrin Fischer from comment #47) > > If Aleisha says the GUI will be next, I am not so worried about the status > > and such. It would be nice to see the code, but I feel this was just > > planning ahead and would not cause harm for now. > > For now no. But when the GUI will be there the message will be marked as > "new" even if they have been processed already. If we mark them all as > "processed" when the GUI is added, that will also be wrong: some may have > not still been processed. But that problem will be the same when we add the status column later on - if it's there now or not. I'd just aim for having the GUI same release if possible? I don't see the big issue here I'd rather spent the time to build the GUI then to make it work perfectly without now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #54 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Bug say's it's sponsored.. can we add a Sponsored-by line to at least one of the patches ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #53 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #50) > Comment on attachment 99637 [details] [review] > Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined > > Review of attachment 99637 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref > @@ +376,5 @@ > > yes: Allow > > no: "Don't allow" > > - patrons to submit problem reports for OPAC pages to the library or Koha Administrator. > > + - "<br/>" > > + - "<strong>NOTE:</strong> You must have KohaAdminEmailAddress enabled." > > This isn't actually true is it?.. we use branch email in preference to > KohaAdminEmailAddress so it's just a fallback not a hard requirement. With the 404 redirect in opac-reportproblem.pl it is a hard requirement. Original code was assuming the pref was filled IIRC. > ::: opac/opac-reportproblem.pl > @@ +41,5 @@ > > ); > > > > +if ( !C4::Context->preference('OPACReportProblem') > > + || !C4::Context->preference('KohaAdminEmailAddress') ) > > +{ > > Don't we actually use branchemail in preference to KohaAdminEmailAddress so > this isn't actually a hard requirement? Not what the code is actually doing. Maybe it needs to be adjusted. 105 to_address => C4::Context->preference('KohaAdminEmailAddress'), (In reply to Martin Renvoize from comment #51) > Comment on attachment 99638 [details] [review] > Bug 4461: Simplify recipients code > > Review of attachment 99638 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt > @@ +32,5 @@ > > + [% IF recipient == 'admin' %] > > + Your problem report has been sent to the Koha administrator. > > + [% ELSE %] > > + Your problem report has been sent to the library. > > + [% END %] > > Do we really need to get this specific in the OPAC? > > I'd say we just need to say whether the email was successfully sent or not > and not worry so much whether it's KohaAdminEmail or Library Branch Email.. > the end user doesn't have a way to select who it goes to anyway. > > If we remove this we could simplify the code a little Feel free to submit any follow-ups you wish ;) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #52 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Jonathan Druart from comment #49) > (In reply to Katrin Fischer from comment #47) > > If Aleisha says the GUI will be next, I am not so worried about the status > > and such. It would be nice to see the code, but I feel this was just > > planning ahead and would not cause harm for now. > > For now no. But when the GUI will be there the message will be marked as > "new" even if they have been processed already. If we mark them all as > "processed" when the GUI is added, that will also be wrong: some may have > not still been processed. Agreed, without any way of maintaining the status, I think we should remove it from this bug.. I like the idea of having a UI with Koha for progressing and tracking reported issues but until that time we shouldn't record incorrect status's. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4461] Context-sensitive report a problem screen
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '20

02 Mar '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #51 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment on attachment 99638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99638 Bug 4461: Simplify recipients code Review of attachment 99638: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=446…) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reportproblem.tt @@ +32,5 @@ > + [% IF recipient == 'admin' %] > + Your problem report has been sent to the Koha administrator. > + [% ELSE %] > + Your problem report has been sent to the library. > + [% END %] Do we really need to get this specific in the OPAC? I'd say we just need to say whether the email was successfully sent or not and not worry so much whether it's KohaAdminEmail or Library Branch Email.. the end user doesn't have a way to select who it goes to anyway. If we remove this we could simplify the code a little -- You are receiving this mail because: You are watching all bug changes.

1 0