- Koha-bugs - lists.koha-community.org

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '20

22 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24584 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24584 [Bug 24584] Rewrite optional installation files to YAML -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '20

22 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24583 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24583 [Bug 24583] Rewrite mandatory installation files to YAML -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '20

22 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 22 Feb '20

22 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24712 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24712 [Bug 24712] Use YAML files for some of the update data -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11297] Add support for custom PQF attributes for Z39.50 server searches
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Caroline Cyr La Rose <caroline.cyr-la-rose(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24708 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24708 [Bug 24708] Update Z39.50 server attribute in fr-CA installation file -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #58 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Great work Bernardo, thanks for your efforts here.. All looking good and working as expected for me.. Signing off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98741|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 99395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99395&action=ed… Bug 13897: Surround columns with backticks We have some column's names that need to be surrounded by ` as they are protected keywords ('rows' for instance) Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98507|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 99394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99394&action=ed… Bug 13897: Process description, multiline values and SQL statements in YAML files This patch adds 3 features: 1) Display description of YAML files at install time for frameworks, and fixes it's encoding. 2) Enable use of multiline values, field required 3) Process SQL statements declared in YAML files With this features we can process files with the following generic YAML strucure: --- description: - "File description" tables: - table_name: translatable: [ title, content ] multiline: [ content ] rows: - title: "Example title" content: - "Content:" - "" - "This is the content." id: 1 value: ~ sql_statements: - "UPDATE table_name SET value ='empty' WHERE value IS NULL" ... * file description is now inside the YAML, can have multiple lines. This attribute is expected in all YAML files. * translatable attribute in table declare fields that can be translated * multiline attribute in table declare fields that can have multiple lines of content, they are joined using '\r\n' before insert into database. This is useful to express fields like 'news' content, and to simplify it's translation. '\r\n' is used for correct display in Windows clients. * sql_statements allows to add multiple SQL sentences, not insertions normally, that are executed in order. This features are not needed for the example file of this patch, but will be used in new bugs. To test: 1) Use the same test plan of first patch. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97069|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 99393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99393&action=ed… Bug 13897: Catch the error and warn it Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 21 Feb '20

21 Feb '20

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97068|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 99392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99392&action=ed… Bug 13897: Use YAML files for installer data This patch modifies C4/Installer.pm to add support for loading YAML files into database. As an example of the functionality, optional auth_val.sql file is replaced by auth_val.yml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, translatable values are declared in the YAML files, to ease identification by translate script. Also file description is moved into the yaml file. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. No differences should be found. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0