- Koha-bugs - lists.koha-community.org

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24262 [Bug 24262] Translate installer data in YAML format -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 --- Comment #197 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- >From this commit 70651422a7517338a68e22321d9918757746ef33 Bug 14385: (QA follow-up) Additional changes and fixes @ Biblio.pm:1551 @ sub GetAuthorisedValueDesc { #---- branch if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "branches" ) { - return Koha::Libraries->find($value)->branchname; + my $branch = Koha::Libraries->find($value); + return $branch? $branch->branchname: q{}; } We are actually hiding a data inconsistency. I would recommend to revert that change and fix the failing test properly instead. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24148] New: black magic in Circulation/Returns.
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24148 Bug ID: 24148 Summary: black magic in Circulation/Returns. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org On the newly created job Koha_Master_D9_MDB_Latest: koha_1 | # Looks like you planned 2 tests but ran 1. koha_1 | koha_1 | # Failed test 'AddReturn logging on statistics table (item-level_itypes=0)' koha_1 | # at t/db_dependent/Circulation/Returns.t line 249. koha_1 | Can't call method "itemtype" on an undefined value at t/db_dependent/Circulation/Returns.t line 247. I recreate locally with this configuration (latest MariaDB version), and tried to debug: modified: t/db_dependent/Circulation/Returns.t @ Returns.t:245 @ subtest "AddReturn logging on statistics table (item-level_itypes=0)" => sub { branch => $branch, type => 'return', itemnumber => $item_without_itemtype->{ itemnumber } - }, { order_by => { -asc => 'datetime' } })->next(); + }, { order_by => { -asc => 'datetime' } }); + warn $stat->count; + $stat = $stat->next; is( $stat->itemtype, $blevel_itemtype, "biblio-level itype recorded on statistics for return"); }; subtest 'Handle ids duplication' => sub { Guess what? ->count returns 1 but ->next returns undef! -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 15496] Delete bibliographic record after moving last item to another record(s)
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15496 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #58 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- >From bug 24232 comment 8: Note that the message is meaningless: "The record has X attached items" is only displayed when X=0. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13736] Enable EDS Plugin Patch
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13736 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED CC| |fridolin.somers(a)biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- > The EDS plugin requires 2 files to be patched. Actual version of EDS plugin 17.11 no longer requires those patches -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95884|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use YAML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use XML files for installer |Use YAML files for |data |installer data -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #27 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 96397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96397&action=ed… Bug 13897: Catch the error and warn it -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #26 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Bernardo, I am all good with it, we could improve (performance) later (like one INSERT per file) if needed. Another improvement would be to move the .txt file into the YAML. I would like to see the translator tool ready before we push this one. Did you investigate already the work that needs to be done? I think we should move the already translated strings into a new .po (one .po for all installer files?) I can have a look if you did not already, but prefer to avoid duplication of work :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13897] Use XML files for installer data
by bugzilla-daemon＠bugs.koha-community.org 18 Dec '19

18 Dec '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #25 from David Cook <dcook(a)prosentient.com.au> --- That looks a lot nicer! Since you're going with this approach, perhaps it would be worth turning off AutoCommit, running the INSERTs, and then COMMITing? According to the MySQL documentation, that should be higher performance. Probably easier to handle exceptions that way too. I wonder if we should add more error-handling in the eval{} block as well. I suppose any errors will be caught during $loadyaml->execute(), so maybe that's unnecessary. (Due to my nitpicker nature, I'd suggest $loadyaml be $load_sth instead, but that's really just nitpicking, so feel free to ignore it.) +1 Bernardo -- You are receiving this mail because: You are watching all bug changes.

1 0