- Koha-bugs - lists.koha-community.org

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #75 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Comment 74 is clear.. these patches, as there is a set of alternatives, cannot be tested on the sandboxes as they stand. They do apply however if you know how to pick individual sets.. hence my setting it to needs signoff.. right now with a 'Patch doesn't apply' status it won't be picked up with others. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Axelle Aix-Marseille Université <axelle.clarisse(a)univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |axelle.clarisse(a)univ-amu.fr --- Comment #74 from Axelle Aix-Marseille Université <axelle.clarisse(a)univ-amu.fr> --- The status was changed from "Patch does'nt apply" to "Needs signoff" today. So I tried on a sandbox but it still not works : The sandbox you've requested is not ready. Some problems occurred applying patches from bug 7376: <h1>Something went wrong !</h1>Applying: Bug 7376 Transfer limits should be checked at check-in Applying: Bug 7376: Refactoring subroutines Using index info to reconstruct a base tree... M C4/Circulation.pm Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 7376: Refactoring subroutines The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 7376 - Transfer limits should be checked at check-in 92774 - Bug 7376 Transfer limits should be checked at check-in 93194 - (ANOTHER IMPLEMENTATION) Bug 7376: Refactoring subroutines 93195 - (ANOTHER IMPLEMENTATION) Bug 7376: Fix wrong indentation of CanBookBeReturned 93196 - (ANOTHER IMPLEMENTATION) Bug 7376: Transfer limits should be checked at check-in Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/ANOTHER-IMPLEMENTATION-Bug-7376-Refactoring-subrou-21wcKc.patch . -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 30 Oct '19

30 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #70 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 94857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94857&action=ed… Bug 14697: (QA follow-up) Restore FK on issue_id and adjust tests This patch reintroduces the FK constraint on issue_id. The tests are adjusted to reflect the UNIQUE constraint we also added. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX)
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #101 from Michal Denar <black23(a)gmail.com> --- This patch works but broke me import via z39.50. Without them import working, with do nothing. Can you fix this? Thank you. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #69 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94854&action=ed… Bug 14697: (QA follow-up) Add missing AV category Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #68 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94853&action=ed… Bug 14697: (QA follow-up) Organize tests in subtests This patch organizes the tests better, and adds some more. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #67 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94852&action=ed… Bug 14697: Make controller methods rely on the stashed user This patch adjusts the return values and HTTP status codes, as well as removing the use of C4::Context->userenv. It also makes the date calculation happen on the DB engine in the case of resolving the claim. Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #66 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94851&action=ed… Bug 14697: (follow-up) Rely on the UNIQUE constraint and return 409 for issue_id This patch avoids querying the DB for an already existing Koha::Checkouts::ReturnClaim with the same issue_id, now that there's a UNIQUE constraint on it. Also, 409 should be returned instead. Tests added for this changes. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: tests pass! Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14697] Extend and enhance "Claims returned" lost status
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '19

29 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #65 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 94850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94850&action=ed… Bug 14697: Schema updates Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew(a)bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0