- Koha-bugs - lists.koha-community.org

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '19

12 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #211 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Some doubts here: 1) Koha vs. C4 This adds quite some new code to the C4 namespace: AddHoldGroup DeleteHoldGroup GetHoldGroupHolds GetReserveCount We already have started to move to Hold.pm and Holds.pm in the Koha namespace. I feel like the new things (*HoldGroup*) at least should be started in the new namespace... someone else might weigh in here. Also uses lots of SQL. 2) Database changes The database update looks quite complicated, because you try to catch that the holds_groups could already exist. I feel it could be simplified. The holds groups table only consists of a PK column? I think the charset is not correct, should be: 3) Had the same question looking at the new method added: + # TODO: Should be: $reserve_cnt = $patron->holds->count; + $reserve_cnt = GetReserveCount( $borrowernumber ); 4) Rename test file (must have missed the global renaming :) ) 5) How does this feature affect limits on holds? (total and daily limits). Will every hold be counted as before? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '19

12 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #210 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I am having issues with the Schema updates. I tried to skip Bug 15516: (follow-up) Schema updates in favor of runing the dbic command myself later, but Bug 15516: Fixing missing curly bracket looks like there are also manual changes? Can you please keep the automated updates in a separate patch and rebase? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '19

12 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Forgot to run yarn build --view opac It's better now, but problems still remain with spaces and 'for reference' label. [] show... but I can't copy and paste them from the OPAC to here? With C&P: Items available for loan: CentervilleCall number: 005.13/3 (1). Centerville Staff CollectionCall number: 005.13/3 (2), Centerville OrderedCall number: 005.13/3 (1). Damaged (1). Manually edited: Items available for loan: Centerville[Call number: 005.13/3] (1). Centerville Staff Collection[Call number: 005.13/3] (2), Centerville Ordered[Call number: 005.13/3] (1). Damaged (1). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '19

12 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #21 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- My example: Record with 4 items: - 1 damaged + Staff collecton - 1 ordered - 1 Staff collection - 1 'without' status -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '19

12 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, but something is not working quite right here still. I get quite unreadable output in the OPAC :( With this patch: Availability: Items available for loan: CentervilleCall number: 005.13/3 (1). Centerville Staff CollectionCall number: 005.13/3 (2), Centerville OrderedCall number: 005.13/3 (1). Damaged (1). Before: Availability: Items available for loan: Centerville [Call number: 005.13/3] (1). Items available for reference: Centerville [Call number: 005.13/3] (1). Damaged (1). On order (1). - Can we please bring back the [] for now? - Totally missing the: 'Available for reference' label? - I am also tempted to say 'kill Call number', but we should concentrate on one change at a time here. We should focus on the 'not for loan' descriptions here first. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '19

12 Oct '19

1 0

[Bug 4042] Public OPAC search can fall prey to web crawlers
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '19

12 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to tecnicouncoma from comment #10) > Hi people. I tried robots.txt and nothing happend. I installed Koha in an i7 > computer with 16G RAM. > > We are rebooting the system twice a day because of the DoS. > > ¿Any alternative procedure to follow? > > Thx, Hi, I think you might want to ask on the mailing list how others have dealt with the problem. If your robots.txt was added correctly and the bots are ignoring it, you might want to try and block them by IP in the firewall. There is also the OPACPublic systm preference that will only allow people to search after being registered (to anser comment#9) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4042] Public OPAC search can fall prey to web crawlers
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '19

11 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4042 tecnicouncoma <tecnicouncoma(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tecnicouncoma(a)gmail.com --- Comment #10 from tecnicouncoma <tecnicouncoma(a)gmail.com> --- Hi people. I tried robots.txt and nothing happend. I installed Koha in an i7 computer with 16G RAM. We are rebooting the system twice a day because of the DoS. ¿Any alternative procedure to follow? Thx, -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '19

11 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Jessie Zairo <jzairo(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo(a)bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results.
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '19

11 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 ByWater Sandboxes <bws.sandboxes(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92496|0 |1 is obsolete| | --- Comment #19 from ByWater Sandboxes <bws.sandboxes(a)gmail.com> --- Created attachment 94026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94026&action=ed… Bug 7611: Change negative notforloan as well This makes the changes apply to both positive and negative notforloan values The extra line generated before is removed Some spans are added and cleaned up and labels moved to CSS to allow for easier altering where needed Itemtypes marked notforloan remain as reference, the label can be changed via css To test: 1 - Have a record with items in various statuses, ideally - 3 available, with 2 in one branch, 1 in another - 3 with itemtype not for loan, 2 in one branch, 1 in another - 3 in a positive not for loan status, 2 and 1 as above - 3 in a negative not for loan status, 2 and 1 as above - 1 in a different positive loan status, but with the same opac description as the negative above 2 - Search the opac to include this record, take a screenshot 3 - Apply patch 4 - Restart all and refresh 5 - Compare to screen shot 6 - Differences include: - Positive statuses are now on separate line with opac description showing - Unavailable (not for loan items) now include callnumber and branch in display - Positive and negative notforloan with same description are combined where branches match - Inspect the elements, note new spans around 'Items available for loan/reference' 7 - Add to OPACUserCSS: .ItemSummary .ItemBranch{ display:none; } .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary .LabelCallNumber{ display:none; } 8 - Note the branches are hidden, and callnumbe rhidden for unavailable items Signed-off-by: Jessica Zairo <jzairo(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0