- Koha-bugs - lists.koha-community.org

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '19

08 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #183 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Ere Maijala from comment #178) > It's all pretty much standalone and shouldn't affect normal Zebra services > in any way. Is there something that's particularly scary? At a glance, it does look pretty standalone. However, could a more normative example/documentation be provided? I'm guessing that most people will never use this daemon so will never have to worry about it either? The number of patches makes it a bit challenging to see what's going on at a glance, but it looks fairly light. I don't understand some of what's going on here, but if I'm never going to use this feature, I'm probably not going to worry about looking at it. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '19

08 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #182 from David Cook <dcook(a)prosentient.com.au> --- Comment on attachment 91736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91736 Bug 13937: Fix RPN conversion Review of attachment 91736: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=139…) ----------------------------------------------------------------- Can this be explained a bit more? Why is this necessary? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
by bugzilla-daemon＠bugs.koha-community.org 08 Oct '19

08 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle(a)bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com --- Comment #288 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 0) There is a QA script fail: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroups.tt OK filters FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 122) 1) Not sure about the naming of these: ordered_titles_count, received_titles_count Not a blocker, just noting (no blocker) 2) Effects on EDI I wonder if the change to closeddate affects EDI. Asking Kyle/Martin to have a look. 3) When there are no basket groups yet, the link in the sidebar leads to an empty page. It might be nicer to display a little message. 4) The datatable on the new basket group page is broken: TypeError: $(...).kohaDataTable is not a function 5) When you are on the pages of a vendor, there is a tab labelled 'Basket groups' and there is also a link now below with the same label. This could be confusing. Not sure what to do about that - noting it to see if someone has a good idea. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11514] Untranslatable "Uncertain" text in acq
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- While I think the patch doesn't break anything, it doesn't make sense to me. 1) Uncertain doesn't show on the basket page now, but I am almost certain that it used to. So the patch might be seen as a bug fix. 2) For invoices: A basket that has an uncertain price in it cannot be closed. Order from an unclosed basket cannot be added to invoices - so I am not sure how to test the second change. Back to Christophe for help with the test plan - or maybe someone else can help? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen(a)gmail.com |katrin.fischer(a)bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer(a)bsz-bw.de --- Comment #29 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 1) QA tools fail: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 111 ( [% description %]) missing_filter at line 113 ( [% itemtype %]) 2) It looks like this is only implemented for MARC21 (XSLT) - can we please add a note to the system preference description to document that? 3) While you are editing that file... could we shorten the options in the pull down a bit by putting the shared part into the text? Then the pull down would only be: 'Koha biblio level itemtype' and 'MARC control fields'. 4) When there is no itemtype image set, there is nothing displayed. Might be intended behaviour - so just noting. (no blocker) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88400|0 |1 is obsolete| | --- Comment #161 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93856&action=ed… Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88399|0 |1 is obsolete| | --- Comment #160 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93855&action=ed… Bug 11879: Remove unecessary code in controller - adds the field required is defined in BorrowerMandatoryField (staff only) - removes code from controller (not needed, we can follow existing pattern) - does not send patron's attribute separately (we have the 'patron' variable already) Need to be done: - same changes for the OPAC - remove extra changes made to moremember-brief.tt (if bugfix it needs to be moved on a separate bug report) - deal with PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField I first thought it would have replaced AutoEmailPrimaryAddress, but it actually only needed for display purpose, how/where can we explain that? Are release notes enough? Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88398|0 |1 is obsolete| | --- Comment #159 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93854&action=ed… Bug 11879: Schema updates Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 07 Oct '19

07 Oct '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Bin Wen <bin.wen(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88397|0 |1 is obsolete| | --- Comment #158 from Bin Wen <bin.wen(a)inlibro.com> --- Created attachment 93853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93853&action=ed… Bug 11879: (QA follow-up) Fix problems found in code review Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Signed-off-by: Bin Wen <bin.wen(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0