- Koha-bugs - lists.koha-community.org

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 --- Comment #76 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- We've not released yet.. perhaps we could change it to in_iprange quickly before it's set in stone forever more. What do you think David, does that sound more appropriate? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 Mason James <mtj(a)kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj(a)kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #146 from Agustín Moyano <agustinmoyano(a)theke.io> --- Created attachment 89929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89929&action=ed… Bug 14570: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #44 from David Cook <dcook(a)prosentient.com.au> --- Just sharing that I have a patch in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 that turns off the alert bit when using checked_in_ok, if that's of interest to people. We're having issues with SIP2 sorters because the alert is causing incorrect sorting for books that haven't been checked out, even when using checked_in_ok (which removes the screen message and marks it as OK). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #75 from David Cook <dcook(a)prosentient.com.au> --- This is cool, but it's unfortunate the name "ipset" was used, since that's an actual tool that can be used for managing IP sets in the Linux kernel: http://ipset.netfilter.org/ipset.man.html When I saw the function name "in_ipset", I was confused until I saw that we weren't actually using ipset and it was just coincidental naming. Not a criticism. Just sharing my initial confusion with the naming. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #7 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 89928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89928&action=ed… Bug 15221 - SIP server always sets the alert flag when item not returned The checked in response from the ACS always has the alert bit set to true, even when using the checked_in_ok option. This patch sets the alert bit to 0 when checked_in_ok is used and the item is checked in without a preceding checkout. To test: 0) Create patron in web interface with a cardnumber and userid of "staff" with a password that matches the account in SIPconfig.xml. Also set their branch to CPL (also matching SIPconfig.xml). 1) Create an item with a barcode of 'test' 2) Choose a patron to check out to and record their borrowernumber In one terminal: 3) cd to your git directory (e.g. /home/koha/koha) 4) perl ./C4/SIP/SIPServer.pm ~/koha-dev/etc/SIPconfig.xml In another terminal: 5) cd to your git directory (e.g. /home/koha/koha) 6) perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> NOTE: You need to replace <borrowernumber> with the borrowernumber from Step 2, and <password> with the password from Step 0. Before patch: koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|COStaff1|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 00310320190521 003103APCPL|AOCPL|ABtest|AC<password>|BIN| READ: 101YNY20190521 003106AOCPL|ABtest|AQCPL|AJTest| After patch: koha@9ec653ab82ce:~/koha$ perl ./misc/sip_cli_emulator.pl -l CPL -su staff -sp <password> --port=6001 --address=localhost --item test -m checkin --patron <borrowernumber> Attempting socket connection to localhost:6001...connected! SEND: 9300CNstaff|CO<password>|CPCPL| READ: 941 Trying 'checkin' SEND: 09N20190521 01000020190521 010000APCPL|AOCPL|ABtest|AC<password>|BIN| READ: 101YNN20190521 010004AOCPL|ABtest|AQCPL|AJTest| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15221] SIP server always sets the alert flag when item not returned
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SIP server always sets the |SIP server always sets the |alert flag |alert flag when item not | |returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #6 from David Cook <dcook(a)prosentient.com.au> --- According to http://multimedia.3m.com/mws/media/355361O/sip2-protocol.pdf, it seems like it's up to the ACS to decide when to raise an alert... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15221] SIP server always sets the alert flag
by bugzilla-daemon＠bugs.koha-community.org 21 May '19

21 May '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15221 --- Comment #5 from David Cook <dcook(a)prosentient.com.au> --- Is it just me or does there appear to be next to no extant documentation on SIP2 extensions? The best I can find is: https://help.oclc.org/Library_Management/WorldShare_Circulation/Release_not… https://sourceforge.net/p/jsip2/wiki/Home/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0