- Koha-bugs - lists.koha-community.org

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #78 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 88367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88367&action=ed… Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85069|0 |1 is obsolete| | --- Comment #77 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 88366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88366&action=ed… Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79348|0 |1 is obsolete| | --- Comment #76 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 88365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88365&action=ed… Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #75 from Pierre-Marc Thibault <pierre-marc.thibault(a)inlibro.com> --- Created attachment 88364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88364&action=ed… Bug 12446: Enable an adult to have a guarantor Concflicts has been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenerios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional mostly to set it by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantiee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantiee bouton; 3) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validade Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validade Garantor information/Main address/Contact fieldsets filled; 8) Validade Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantiee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantiee bouton; 6) Validade Garantor information/Main address/Contact fieldsets filled; 7) Validade Garantor additional alternate address/contact filled; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84022|0 |1 is obsolete| | --- Comment #144 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> --- Created attachment 88363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88363&action=ed… Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84021|0 |1 is obsolete| | --- Comment #143 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> --- Created attachment 88362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88362&action=ed… Bug 11879: Remove unecessary code in controller - adds the field required is defined in BorrowerMandatoryField (staff only) - removes code from controller (not needed, we can follow existing pattern) - does not send patron's attribute separately (we have the 'patron' variable already) Need to be done: - same changes for the OPAC - remove extra changes made to moremember-brief.tt (if bugfix it needs to be moved on a separate bug report) - deal with PatronSelfModificationBorrowerUnwantedField and PatronSelfRegistrationBorrowerUnwantedField I first thought it would have replaced AutoEmailPrimaryAddress, but it actually only needed for display purpose, how/where can we explain that? Are release notes enough? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84020|0 |1 is obsolete| | --- Comment #142 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> --- Created attachment 88361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88361&action=ed… Bug 11879: Schema updates Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84019|0 |1 is obsolete| | --- Comment #141 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> --- Created attachment 88360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88360&action=ed… Bug 11879: (QA follow-up) Fix problems found in code review Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11879] Add a new field to patron record: main contact method
by bugzilla-daemon＠bugs.koha-community.org 19 Apr '19

19 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84018|0 |1 is obsolete| | --- Comment #140 from José-Mario Monteiro-Santos <jose-mario.monteiro-santos(a)inlibro.com> --- Created attachment 88359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88359&action=ed… Bug 11879: (follow-up) Streamline markup and make label corrections This patch makes minor markup corrections to the patron detail page template: - Simplify the SWITCH markup - Add "primary" to primary phone label - Correct case on label - Add IF statement to hide label if there is no primary contact method Signed-off-by: Lucie Gay <lucie.gay(a)ens-paris-saclay.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0