- Koha-bugs - lists.koha-community.org

[Bug 14956] Remove C4::Dates from files opac/*.pl
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14956 --- Comment #25 from David Gustafsson <glasklas(a)gmail.com> --- Created attachment 88203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88203&action=ed… Bug 14957: Put database updates in perl script Also add schema changes to kohastructure.sql and syspref to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #79 from Liz Rea <wizzyrea(a)gmail.com> --- we might want to rebase out the old .sql files, but I don't want to mess it up so I will leave that bit. That's the only QA fail I can see, the newest patch resolves Katrin's concerns, near as I can tell. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14715] Results per page setting for catalog search in staff client and OPAC
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88126|0 |1 is obsolete| | --- Comment #78 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 88195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88195&action=ed… Bug 14715: (follow-up) Fixing database updates This patch removes the atomic update that adds the 'perPage' system preferences and keeps the 'dropdown' system preferences. Also sql file is moved into perl file. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- (In reply to Andrew Isherwood from comment #43) > (In reply to Katrin Fischer from comment #42) > > Hi Andrew, > > > > sorry, we are almost there. Most things worked really well (like checkbox > > visibility), but found one case that didn't work as expected: > > > > HoldOverride = Allow > > LimitOverride = Not allowed > > > > Item is on hold, 2 of 2 renewals remaining. > > Staff user has override permission. > > > > But: Checking the checkbox doesn't make the item renewable. > > Hi Katrin, > > The test plan specifies that LimitOverride needs to be enabled for the > functionality to work. If it's disabled the click listener on the override > checkbox isn't created, which explains why it doesn't do anything. This > isn't something that has been modified in my patches, it's pre-existing Koha > functionality. Are you expecting something different? Hm, maybe the checkbox should now shop up in this case then? Right now the checkbox just appears to have no effect - and if I understand you correctly that's the expected behaviour as both need to be allowed to work? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7088] Cannot renew items on hold even with override
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #43 from Andrew Isherwood <andrew.isherwood(a)ptfs-europe.com> --- (In reply to Katrin Fischer from comment #42) > Hi Andrew, > > sorry, we are almost there. Most things worked really well (like checkbox > visibility), but found one case that didn't work as expected: > > HoldOverride = Allow > LimitOverride = Not allowed > > Item is on hold, 2 of 2 renewals remaining. > Staff user has override permission. > > But: Checking the checkbox doesn't make the item renewable. Hi Katrin, The test plan specifies that LimitOverride needs to be enabled for the functionality to work. If it's disabled the click listener on the override checkbox isn't created, which explains why it doesn't do anything. This isn't something that has been modified in my patches, it's pre-existing Koha functionality. Are you expecting something different? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14723] Additional delivery notes to messages
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #31 from Josef Moravec <josef.moravec(a)gmail.com> --- Comment on attachment 87531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87531 Bug 14723: Additional delivery notes to messages Review of attachment 87531: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=147…) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +1272,5 @@ > unless ($patron) { > warn "FAIL: No 'to_address' and INVALID borrowernumber ($message->{borrowernumber})"; > _set_message_status( { message_id => $message->{'message_id'}, > + status => 'failed', > + delivery_note => 'Invalid borrowernumber '.$message->{borrowernumber} } ); These notes are untranslatable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3766] Cities/Towns only on one address
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick(a)bywatersolutions.com --- Comment #12 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 11969] Show patrons star rating on their reading history
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick(a)bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick(a)bywatersolutions.com> --- Awesome work all! Pushed ot master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #154 from Michal Denar <black23(a)gmail.com> --- Hi there, patch works. Great work. I've just one notice. If somebody use this feature to hold to pull (reserve on title with available item). It's wrong process, I know it. But some libraian can make this fault. In this case tool don't delete reserves on next titles. I'm not sure that is an error. It's same behaviour from earlier version of Place hold on more than one title. Ideas: - if title with available item is add into group, Koha show kind of info text (easy solution) - if somedoby try to add title with available item, Koha don't allow it with message What do you think about it? Thank you. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] Allow to place a hold on first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 17 Apr '19

17 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #153 from Michal Denar <black23(a)gmail.com> --- Created attachment 88186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88186&action=ed… Bug 15516: (follow-up) Changing utf8 to utf8mb4 Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0