- Koha-bugs - lists.koha-community.org

[Bug 14570] Make it possible to add multiple guarantors to a record
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen(a)gmail.com | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Sorry, I forgot that git bz would not obsolete the first patch automatically because I had changed the subject line :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86574|0 |1 is obsolete| | --- Comment #38 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 87993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87993&action=ed… Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15253] Add Koha::Logger based logging for SIP2
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84553|0 |1 is obsolete| | --- Comment #220 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 87991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87991&action=ed… Bug 15565: (follow-up) fixing typo that breaks placing a hold -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84552|0 |1 is obsolete| | --- Comment #219 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 87990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87990&action=ed… Bug 15565: (follow-up) Place multiple holds from opac-search.pl Previously before this patch if you selected multiple bibliographic results from opac-search.pl and selected 'Place hold' and confirmed the hold only 1 hold on the first of the selected biblios would be placed. This patch fixes this bug and enables users to be able to place holds on multiple bibliographic records in opac-search.pl, select 'Place hold', select if they want each of these holds to be on 'Next available', 'Next available from group', or 'A specific item' and place their holds and all the holds they placed will be placed correctly. Test plan: 1. Follow test plan on the last patch - (Don't apply this patch) 2. Try to select multiple bibliographic record checkboxes and select 'Place hold' 3. Confirm holds and notice you are re-directed to opac-user.pl and only the first hold has been placed 4. Apply this patch 5. Restart memcached and plack if running 6. Repeat steps 2 and 3 and notice all holds were placed 7. Repeat step 2 and then select a variety of 'A specific item' and 'Next available item' holds for each of the bibliographic holds and confirm they are all placed correctly 8. Confirm you can still place multiple holds correctly in opac-reserve accessing from a OPAC biblio detail page Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84551|0 |1 is obsolete| | --- Comment #218 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 87989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87989&action=ed… Bug 15565: (follow-up) Changes to maximum hold allowed logic Implemented changes to the logic to address Katrin Fischer's points in comment #175, also changed the modal box wording to use 'hold' not 'reserve' Also updated t/db_dependent/Reserves/MultiplePerRecord.t test to reflect moving function. Added the display of the JS modal box informing OPAC borrower that they have exceeded hold limit after they click 'A specific item' radiobutton on opac-reserve if holds per day, holds per record or maxreserves is 1 Test plan: 1. Apply patches 2. Restart memcached and plack 3. Run t/db_dependent/Reserves/MultiplePerRecord.t 4. Set your maxreserves syspref to 3, and a circ rules holds per record to 2 and holds per day to 1 5. In the OPAC visit the 'Place hold' interface of item. Select the 'A specific item' radiobutton and observe the first item checkbox is checked and other unchecked checkboxes are disabled. 6. Repeat step 4 this time setting holds per day to 5 7. Now reloading the OPAC 'Place hold' page notice after clicking 'A specific item' no modal displays 8. Select a second item checkbox and observe a modal saying you have reached the maximum number of holds for the record is loaded - notice the wording 'hold' not 'reserve' in use in the modal box 9. Click 'OK' on modal and observe all unchecked item checkboxes are automatically disabled to prevent additional holds being placed 10. Select 'Confirm hold' 11. On your holds summary page confirm both holds are placed 12. In the staff client set the 'AllowHoldPolicyOverride' syspref to "Don't allow" 13. Visit a biblio reservation interface in the staff client 14. Select 2 item checkboxes and observe the modal box explaining you have reached maximum holds for the record is displayed - notice the wording of 'hold' not 'reserve' is used in the modal box. 15. Select 'OK' on the modal and notice all un-checked item checkboxes are automatically disabled 16. Repeat steps 12-15 this time with the value of 'AllowHoldPolicyOverride' syspref set to 'Allow' and notice that once you have clicked on the second item checkbox although the modal still loads the item checkboxes do not disable - you are able to override and continue selecting checkboxes each time with modal warning loading. 17. In both the OPAC and staff client try placing a record level hold, selecting a value from the 'Holds to place (count)' dropdown. Notice that the maximum value of this is the lowest value out of the 'maximum number of holds per record', 'maximum number of holds per day' and the 'maxreserves' system preference so in this case it will be 2 18. Save and notice 2 holds are placed 19. Observe the allow_holds() function is in the Koha/Biblio.pm file and the GetAllowedHoldsForPatronToday() function has been removed from C4/Reserves.pm Sponsored-By: Brimbank Library, Australia -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84550|0 |1 is obsolete| | --- Comment #217 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 87988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87988&action=ed… Bug 15565: (QA follow-up) Fix some last filters Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '19

15 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Aleisha Amohia <aleisha(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84549|0 |1 is obsolete| | --- Comment #216 from Aleisha Amohia <aleisha(a)catalyst.net.nz> --- Created attachment 87987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87987&action=ed… Bug 15565: (follow-up) Removed leftover debug code and added missing filters Sponsord-By: Brimbank Library, Australia Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0