- Koha-bugs - lists.koha-community.org

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84689|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87501&action=ed… Bug 15326: (follow-up) Interface fixes This patch addresses the following: a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84688|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87500&action=ed… Bug 15326: (follow-up) Code review fixes Addresses the following issues: b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84687|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87499&action=ed… Bug 15326: (follow-up) Fix tools menu highlighting Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84686|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87498&action=ed… Bug 15326: (follow-up) Don't make links to unpublished pages in opac Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84685|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87497&action=ed… Bug 15326: (follow-up) Move js to footer, use Asset plugin Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84684|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87496&action=ed… Bug 15326: (follow-up) utf8 to utf8mb4 Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84683|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87495&action=ed… Bug 15326: (follow-up) Add CMS feature This patch builds on Martin Persson's patch. I made a few changes that improve the patch and make this feature functional. The only thing I am not completely satisfied with (and doesn't reliably work) is the navigation for the CMS pages on both the staff side and the OPAC side. This needs work. Otherwise the CMS feature works. - Make sure you update database after applying patch - After adding a few pages, confirm that filtering results works (play with different combinations of display location, library and language) - Confirm that pages with specific locations ONLY show up in those locations, i.e. OPAC pages can only be accessed in OPAC and staff interface pages can only be accessed on staff client - Confirm that table is showing correct data, particularly language, location and library - Confirm that if page has not been published and user does not have permission to edit pages, page content will not display on OPAC side. On staff side, a message will show saying that page has not been published - Confirm pagination for table shows and works - Confirm deleting pages works as expected (confirm message before delete) - Confirm link title must be unique when adding new pages - Confirm that editing the details of an existing page works - Confirm that adding a child page will only work if the location of child page matches location of parent page, i.e., if parent page is an OPAC page then child page must also be OPAC page. if parent page is in all locations then child page can be in all or either interface(s) - Confirm Select All/Clear All toggle works - Confirm viewing of CMS pages in OPAC and in staff client works and looks nice Sponsored-by: Region Halland Bug 15326: [FOLLOW-UP] Many fixes This patch: - moves action buttons into a dropdown, adds a delete button to dropdown - fixes the tests (they should now all pass) - fixes qa tool problems - removes the Koha::CmsPages->remove() method (unnecessary) - makes changes to the Koha::CmsPages->add() method (now simpler, easier to test) This is now ready to test. Sponsored-by: Catalyst IT Bug 15326: [FOLLOW-UP] More fixes This patch removes the t/Pages.t file because it isn't required, and other unused methods. This patch is ready to test. The appropriate tests are in t/db_dependent/Pages.t Bug 15326: [FOLLOW-UP] adding and editing fixes Sorry, did not see the second half of your comment. This patch should fix the adding and editing issues in Comment 16. Bug 15326: [FOLLOW-UP] Fixing library field in form, opac publishing Fixes issues from Comment 19, please test Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84682|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87494&action=ed… Bug 15326: Add CMS feature INCOMPLETE - For evaluation purposes only! Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> Signed-off-by: Michal Denar <black23(a)gmail.com> Rebased-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22648] New: Typo in SQL in smart-rules.pl
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '19

08 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22648 Bug ID: 22648 Summary: Typo in SQL in smart-rules.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Target Milestone: --- Trailing comma in the update statement 349 my $sth_update = $dbh->prepare(q| 350 UPDATE default_borrower_circ_rules 351 SET maxissueqty = ?, 352 maxonsiteissueqty = ?, 353 WHERE categorycode = ? 354 |); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 12

[Bug 22654] New: Not available
by bugzilla-daemon＠bugs.koha-community.org 07 Apr '19

07 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22654 Bug ID: 22654 Summary: Not available Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs(a)lists.koha-community.org Reporter: adibondrat01(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Created attachment 87483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87483&action=ed… Touched honney Positif thinking honney -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2