- Koha-bugs - lists.koha-community.org

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87120|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87299&action=ed… Bug 10796: Use $category->effective_change_password in the OPAC This patch makes the OPAC pages that rely on OpacPasswordChange use the current patron's category to make the decision to allow password change or not. It does so by making sure all the places in which OpacPasswordChange was used, use $logged_in_user->category->effective_change_password instead. Special attention is required on the case of opac-registration-verify.pl in which the use of an unblessed Koha::Patron object is changed in favour of the blessed object, so we can actually use the new method to make a decision on the text to display. To test: - Go through the OPAC pages, check that the password change strings and links are displayed only whne appropriate. - Sign off :-D Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87119|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87298&action=ed… Bug 10796: Handle can_change_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87118|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87297&action=ed… Bug 10796: Add Koha::Patron::Category->effective_change_password method This method checks whether the local $self->change_password is set to override the OpacPasswordChange syspref (i.e. if it is set to a bool) or undef, in which case it falls back to the value of the syspref To test: - Apply this patches - Make sure the DB is updated: $ updatedatabase - Update the schema files: $ dbic - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10796] Allow OpacPasswordChange to be set by category type
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87117|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 87296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87296&action=ed… Bug 10796: DB update Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13895] Add routes for checkouts retrieval and renewal
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com --- Comment #87 from Lucas Gass <lucas(a)bywatersolutions.com> --- missing dependencies and wont be backporting to the 18.05.x series -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 22608] New: Authentication with Google oAuth does not inherit Default Messaging Preferences from default user category
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22608 Bug ID: 22608 Summary: Authentication with Google oAuth does not inherit Default Messaging Preferences from default user category Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs(a)lists.koha-community.org Reporter: costalc(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Target Milestone: --- GoogleOpenIDConnectDefaultCategory defines the category of a new user when it is created after oAuth authentication and GoogleOpenIDConnectAutoRegister is ON (Allow). This procedure should inherit category's Default Messaging Preferences but now it does not. It would be nice if it could. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com --- Comment #27 from Lucas Gass <lucas(a)bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2096] Label sources for OPAC descriptions
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2096 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea(a)gmail.com Status|REOPENED |In Discussion --- Comment #6 from Liz Rea <wizzyrea(a)gmail.com> --- Hi Marjorie, Could you supply a record that clearly demonstrates this problem? Just easier when we can see what you see. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 22565] New: Partially receiving order and adding internal note on invoice updates note on every order on the system
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Bug ID: 22565 Summary: Partially receiving order and adding internal note on invoice updates note on every order on the system Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: janet.mcgowan(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org Target Milestone: --- Tested on 18.11.01 and 18.11.03 If you have an order for multiple copies and only receipt one or more of those copies but not the entire number, and edit the internal note field on the invoice screen, the internal note field then updates every order on the system. The internal note is applied to all orders but also it overwrites any other note that was there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 01 Apr '19

01 Apr '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Lucas Gass <lucas(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas(a)bywatersolutions.com --- Comment #13 from Lucas Gass <lucas(a)bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes.

1 0