- Koha-bugs - lists.koha-community.org

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #41 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Saw this warning once: Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc line 84. False warning from qa tools: Koha/Patron/Attribute.pm critic/forbidden patterns: forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 127) A dumb question: + return Koha::Patron::Attributes->search({ + borrowernumber => $self->borrowernumber, + branchcode => $self->branchcode, + }); => Is the branchcode needed? Koha/Patron/Attribute.pm L114 return $av->next->lib if $av->count Amended: adding a semicolon for future ease. Koha/Schema/Result/BorrowerAttribute.pm => Please do not add DBIx schema files in a regular patch. I removed it now. Btw it seems no longer necessary if we rename the relation in the Koha object. See follow-up. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86168|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Comment on attachment 86168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86168 Bug 12159: (QA follow-up) Silencing POD warn from qa tools No longer needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12159] Duplicate borrower_add_additional_fields function
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85019|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86881&action=ed… Bug 13735: Update PrepareItemrecordDisplay to use maxlength The PrepareItemrecordDisplay method used to generate the item display on receiving serials was using a hardcoded maxlength of 255 on input fields. This patch updates it to use the maxlength defined in the frameworks instead as the normal item form does. To test: - Create or reuse an existing subscription - Make note of the framework the record uses - Add an item on receive - Check the maxlength on the various fields is set to 255 (check source code or use developer tools) - You can also verify that by adding a long note to one of the note fields - Apply patch - Repeat tests, the maxlength should now be 9999 - In your framework settings, change the length of one of the subfields to another value - Verify that the item form reflects the change Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13735] Item form in serials module doesn't respect max length set in the frameworks
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy(a)rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #6) > With my QA hat on.. I don't think we should require a test here.. the code > is hideously integrated and a test would end up being more complicated than > the fix itself.. When it comes to refactoring this into Koha:: we will need > lots of tests to cover these routines, spreading from integrations ui tests > down to module unit tests. > > Just my opinion for the next QAer to come along. Yeah, no problem. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 22 Mar '19

22 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #81 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Applying: Bug 15326: Add CMS feature .git/rebase-apply/patch:191: tab in indent. -asc => [qw/parent location branchcode lang sortorder/] .git/rebase-apply/patch:241: tab in indent. my ( $self, $id ) = @_; .git/rebase-apply/patch:243: tab in indent. carp( 'Missing CMS page id parameter in Koha::Pages::page' ) unless defined $id; .git/rebase-apply/patch:245: tab in indent. # Probably want to merge these to a single query: .git/rebase-apply/patch:246: tab in indent. my $top_links = $self->_resultset()->search( warning: squelched 77 whitespace errors warning: 82 lines add whitespace errors. Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/userpermissions.sql M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt M opac/opac-main.pl .git/rebase-apply/patch:191: tab in indent. -asc => [qw/parent location branchcode lang sortorder/] .git/rebase-apply/patch:241: tab in indent. my ( $self, $id ) = @_; .git/rebase-apply/patch:243: tab in indent. carp( 'Missing CMS page id parameter in Koha::Pages::page' ) unless defined $id; .git/rebase-apply/patch:245: tab in indent. # Probably want to merge these to a single query: .git/rebase-apply/patch:246: tab in indent. my $top_links = $self->_resultset()->search( warning: squelched 77 whitespace errors warning: 82 lines applied after fixing whitespace errors. CONFLICT (content): Merge conflict in opac/opac-main.pl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Patch failed at 0001 Bug 15326: Add CMS feature -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8000] Test mode for notices
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '19

21 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #168 from Liz Rea <wizzyrea(a)gmail.com> --- Created attachment 86865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86865&action=ed… Bug 8000: (QA follow-up) Add email validation to system preferences This patch uses the JQuery validator plugin to add validation to preferences of class email in the system preferences page. A field containing an invalid value (even if not modified) should prevent saving. To test, confirm that when entering an invalid email address in the SendAllEmailsTo field, an error message appears and saving is prevented. Correcting the value should hide the message and let you save as normal. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0