- Koha-bugs - lists.koha-community.org

[Bug 6473] Test bug for Git-bz
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #221 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 86644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86644&action=ed… Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I tried to avoid storing rounded values it is required for tax generation. This patch makes that change and adds test coverage and POD for populate_order_with_prices To test: Follow plan on other patches, ensure that orders and totals match on the basket, invoice, and budget pages prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14825] Accounts Rewrite Omnibus
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Janet McGowan <janet.mcgowan(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan(a)ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #28 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86643&action=ed… Bug 14591: (QA follow-up) Fix AddReturn call in Circulation/issue.t Test plan: prove t/db_dependent/Circulation/issue.t Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #27 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86642&action=ed… Bug 14591: (QA follow-up) Optimize DateTime passing We were passing around possibly undefined $return_date variables from AddReturn and then instantiating a new DateTime object as a default for each routine. This followup sets the default higher up the stack within AddReturn which provider clearer logic and a small performance improvment. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #26 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86641&action=ed… Bug 14591: Update unit tests Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #25 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86640&action=ed… Bug 14591: Update other calls to AddReturn Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86618|0 |1 is obsolete| | Attachment #86619|0 |1 is obsolete| | Attachment #86620|0 |1 is obsolete| | Attachment #86621|0 |1 is obsolete| | --- Comment #24 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86639&action=ed… Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | --- Comment #23 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Martin Renvoize from comment #21) > I really like this solution! It tidies up the code significantly and > corrects the logic considerably! > > Signing off as it all works in testing as described... > > Some QA comments for the next in line however. > > * Can we/Should we remove the 'lastincrement' field here as I believe this > was the only use case for it? > * The logic here puts 'dropboxmode/dropboxdate' in precidence to any > specified return date.. I think we perhaps need a bit more in this regard, > but perhaps that can be done within bug 13044 as there's a fair bit of > contextual conversation over there around this issue. I agree to continue on these two points on other reports, as this patchset is ok and fixes the bug. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3484] Break down fee display by types on checkout tab
by bugzilla-daemon＠bugs.koha-community.org 15 Mar '19

15 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3484 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Circulation Summary|Break down fee display on |Break down fee display by |checkout tab |types on checkout tab Status|ASSIGNED |NEW Assignee|jwagner(a)ptfs.com |koha-bugs(a)lists.koha-commun | |ity.org CC| |gmcharlt(a)gmail.com, | |kyle.m.hall(a)gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I still like the idea of this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug.

1 0