- Koha-bugs - lists.koha-community.org

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86601|0 |1 is obsolete| | --- Comment #110 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86610&action=ed… Bug 8995: (follow-up) Tak system preference item-level_itypes into account Signed-off-by: Magnus Enger <magnus(a)libriotech.no> Tested with all 9 current patches. Works as advertised, including OPACURLOpenInNewWindow. If a record has no items, no OpenURL link is displayed. All the suggested tests pass. I did not test with XSLT turned off. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86559|0 |1 is obsolete| | --- Comment #109 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86609&action=ed… Bug 8995: (follow-up) Add one more test fot get_openurl Test plan: prove t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86558|0 |1 is obsolete| | --- Comment #108 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86608&action=ed… Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins Test plan: 1) Ensure the COinS span tag is still included on this pages. You need to look into html source and search for span tag with class 'Z3988', which has COinS string in title. Staff client: catalogue -> ISBDdetail catalogue -> MARCdetail catalogue -> detail virtualshelves -> shelves OPAC (you should have COinSinOPACResults system preference enabled): opac detail opac search opac shelves 2) Run tests: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86557|0 |1 is obsolete| | --- Comment #107 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86607&action=ed… Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86542|0 |1 is obsolete| | --- Comment #106 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86606&action=ed… Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86541|0 |1 is obsolete| | --- Comment #105 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86605&action=ed… Bug 8995: (follow-up) Added test Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86492|0 |1 is obsolete| | --- Comment #104 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86604&action=ed… Bug 8995: (follow-up) Adapt to current codebase Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86491|0 |1 is obsolete| | --- Comment #103 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86603&action=ed… Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86490|0 |1 is obsolete| | --- Comment #102 from Magnus Enger <magnus(a)libriotech.no> --- Created attachment 86602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86602&action=ed… Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 14 Mar '19

14 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0