- Koha-bugs - lists.koha-community.org

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #86 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86484&action=ed… Bug 8995: Remove useless code OpenURL link display is done in XSLT only, so this code is now useless Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8995] Show OpenURL links in OPAC search results
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64532|0 |1 is obsolete| | Attachment #64533|0 |1 is obsolete| | Attachment #64534|0 |1 is obsolete| | Attachment #64535|0 |1 is obsolete| | Attachment #64536|0 |1 is obsolete| | Attachment #64537|0 |1 is obsolete| | Attachment #64538|0 |1 is obsolete| | --- Comment #85 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86483&action=ed… Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi(a)cineca.it> Signed-off-by: Magnus Enger <magnus(a)libriotech.no> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #28 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86460&action=ed… Bug 15400: (follow-up) Restore 'years' string, remove untranslatable string -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #27 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86459&action=ed… Bug 15400: (follow-up) Adding age to check out search dropdown Confirm age shows in the suggestions dropdown when using the checkout search in header (if user set DOB). Confirm 'Age unknown' shows if no DOB set. Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #26 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86458&action=ed… Bug 15400: (follow-up) Updating text display Now shows as 'Born: [date of birth] (age)' in circ sidebar menu and search results Sponsored-by: Catalyst IT Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85495|0 |1 is obsolete| | Attachment #85496|0 |1 is obsolete| | Attachment #85497|0 |1 is obsolete| | --- Comment #25 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 86457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86457&action=ed… Bug 15400: Display date of birth and age more consistantly Test plan: 0) Apply the patch 1) Go to all of these pages Patron detail Other patron pages - look on the left side (circ-menu) Patron search Guarantor search ( go to child patron -> edit -> in guarantor section click "Set to patron" Search through "Check out" (in the header) 2) Confirm that does show date of birth and date consistantly, try it on patrons with and without date of birth set to find possible reggressions Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12747] Add configurable extra column in Z3950 search result
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Jessie Zairo <jzairo(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22492 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15400] Display patron age in useful places
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #52 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 86453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86453&action=ed… Bug 14567: (follow-up) Rename pref and move to Opac section -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14567] Browse interface for OPAC
by bugzilla-daemon＠bugs.koha-community.org 11 Mar '19

11 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0