- Koha-bugs - lists.koha-community.org

[Bug 7890] Highlight required field in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Cori Lynn Arnold from comment #2) > I got this error below when I tried to import a record ... > Could not compile /kohadevbox/koha/cataloguing/addbiblio.pl: Global symbol > "$tab" requires explicit package name (did you forget to declare "my $tab"?) My patch only changes the template, so I think this error has another cause. Did you apply all the dependencies first? Maybe you need to use the "restart_all" command? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11983] Code to select patrons to purge needs to be centralized
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10589] Override OpacHiddenItems based on Patron Branch
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com --- Comment #47 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Please take a look at bug 22454 and bug 22455. The rationale is that if you have the biblio object, you can know all that is needed regarding hiding in OPAC without fetching MARC data or complex calculations. And if we were to add parameters like category and library, I would rather pass the Koha::Patron object altogether. This check, with bug 22457 in mind could be written: my $should_hide = ( $patron->category->overrides_opac_hidding_policy or $patron->library->overrides_opac_hidding_policy ) ? 0 : 1; while ( my $biblio = $biblios->next ) { next if $biblio->hidden_in_opac and $should_hide; do_your_things(); } This check should be written on the controller script. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8775] Add collection code to lost report
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- The sequence of columns appears a little strange: - Library (homelibrary) - Item type - Collection code - Current location (holdinglibrary) - Location Out of scope here, but can we change "Collection code" to be "Collection"? We are not showing the code, but the description :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11969] Show patrons star rating on their reading history
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Comment on attachment 86047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86047 Bug 11969: Show patrons star rating on their reading history Review of attachment 86047: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=119…) ----------------------------------------------------------------- ::: opac/opac-readingrecord.pl @@ +147,4 @@ > } > } > > +for(qw(OPACAmazonCoverImages GoogleJackets SyndeticsCoverImages)) { # BakerTaylorEnabled handled above Why this change? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley(a)catalyst.net.n | |z Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14407] Limit web-based self-checkout to specific IP addresses
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80738|0 |1 is obsolete| | --- Comment #60 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 86123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86123&action=ed… Bug 14407: Follow up to add test case and clean noise Comment #28 has a /36 which is invalid CIDR. This triggers a crash and noise. This cleans up the crash and noise, and adds test cases to check for them. prove t/Auth.t -- before missing null case, and /36 case. -- after null case, and /36 with/without warnings. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> Looked signed off but status was Needs Signoff so I tested it again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15067] Add additional languages to advanced search language search
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84124|0 |1 is obsolete| | --- Comment #13 from Hayley Mapley <hayleymapley(a)catalyst.net.nz> --- Created attachment 86122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86122&action=ed… Bug 15067: Added translations of languages to those 5 languages. Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq are added with their translations to the Advanced Search languages. Test Plan: 1. From homepage, go to Advanced search 2. Click on More options next to the Search button 3. Scroll down to the Limits section 4. Click on Language: No limit 5. Find Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq at the bottom of the dropdown. 6. They should all be there. 7. Estonian and Latvian are repeated, this need to be fixed. 8. They need to be put in alphabetical order. Signed-off-by: Hayley Mapley <hayleymapley(a)catalyst.net.nz> The five languages are present, sorted alphabetically, and are not repeated. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15067] Add additional languages to advanced search language search
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Hayley Mapley <hayleymapley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7890] Highlight required field in MARC editor
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '19

06 Mar '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Cori Lynn Arnold <carnold(a)dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold(a)dgiinc.com Status|Needs Signoff |Failed QA --- Comment #2 from Cori Lynn Arnold <carnold(a)dgiinc.com> --- I got this error below when I tried to import a record ("Sometimes I lie" by Alice Feeney) Steps: 1. Go to Cataloging 2. Click "New from Z39.5/SRU" button 3. Put "Sometimes I lie" in the title field and hit "Search" 4. Click on a row and select "Import" Error: Could not compile /kohadevbox/koha/cataloguing/addbiblio.pl: Global symbol "$tab" requires explicit package name (did you forget to declare "my $tab"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 876. Global symbol "$tab" requires explicit package name (did you forget to declare "my $tab"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 877. Global symbol "$title" requires explicit package name (did you forget to declare "my $title"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 889. Global symbol "$title" requires explicit package name (did you forget to declare "my $title"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 890. Global symbol "$uxml" requires explicit package name (did you forget to declare "my $uxml"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 941. Global symbol "$urecord" requires explicit package name (did you forget to declare "my $urecord"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 944. Global symbol "$uxml" requires explicit package name (did you forget to declare "my $uxml"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 944. Global symbol "$urecord" requires explicit package name (did you forget to declare "my $urecord"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 945. syntax error at /kohadevbox/koha/cataloguing/addbiblio.pl line 961, near ") {" BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/cataloguing/addbiblio.pl line 978. at /usr/share/perl5/CGI/Compile.pm line 132 -- You are receiving this mail because: You are watching all bug changes.

1 0