- Koha-bugs - lists.koha-community.org

[Bug 13044] Deprecate old book drop mode
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '19

17 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 --- Comment #16 from George Williams (NEKLS) <george(a)nekls.org> --- I want the interface and the options displayed on screen to be as simple as possible for staff. 99% of the time staff are using returns.pl, they are doing normal check ins - no book drop mode, no due date other than the current date and time, and they're not forgiving fines. If staff don't need to use the "Specify due date options," why have those options clutter up the screen. Currently, if SpecifyReturnDate is set to Allow, the #return_date_override input box, the date picker calendar, the "Remember for next checkin" checkbox, the "Clear" button, the "Specify return date" hint, and the "Remember for next check in" label appear on the screen whenever returns.pl is open. If staff are doing normal check ins, then all of this stuff is just a distraction on the screen. By having a "Specify due date" checkbox or toggle on the right side of the screen where the "Forgive fines" and "Book drop mode" checkboxes are located, all of that stuff on the screen related to spcifying a due date can be removed from the screen for the 99% of the time that staff are doing normal checkins. Simplicity is the same reason that I'd like a checkbox or a toggle for "Book drop mode." "Book drop mode" is incredibly simple to explain to staff because the words "Book drop mode" are virtually self-explanatory. When you're training front-line staff on checking in items and you talk about how to handle things left in the book drop overnight, all you have to really say is "When you check in items from the book drop every morning, click on the box that says 'Book drop mode.'" The existing "Book drop mode" option communicates its purpose on the screen more efficiently than subordinating that function to the "Specify due date" feature would. No matter how simple we make selecting the last open date when choosing to specify a due date, "Book drop mode" is a much simpler way of communicating the function to the user. "Forgive overdue charges" is simple and easy to understand. "Book drop mode" is simple and easy to understand. A checkbox or toggle for "Specify due date" would also be easy to understand option on the right hand side of returns.pl, especially if checking that box caused all of the specify due date options to display where they are currently displayed under the checkin input box. And having a way of preventing those options from displaying when they are not needed makes this page easier to scan for the 99% of the time staff are doing normal checkins. George -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #16 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Jonathan Druart from comment #15) > What about generate a password if none is provided? You talking about the set_password.pl script? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Sonia, please give this new version a try. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 85211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85211&action=ed… Bug 14293: Add more tests and improve get_chargeable_units Not sure at all about this change, especially because it could modify CalcFine -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42492|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 85210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85210&action=ed… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: Nick Clemens <nick(a)quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21996] sample
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21996 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22282 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 17746] koha-reset-passwd should use Koha::Patron->set_password
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #15 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- What about generate a password if none is provided? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 16714] New: Unexpected logout with "IP address change"
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16714 Bug ID: 16714 Summary: Unexpected logout with "IP address change" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org I get a new issue (not sure since when) under Plack: I am logged out with "IP address change" just after the first login. To reproduce: - logout - restart plack - login - click somewhere => You will be logged out I have tried to debug: diff --git a/C4/Auth.pm b/C4/Auth.pm index 985bd39..a494ddf 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -818,6 +818,9 @@ sub checkauth { $userid = $s_userid; $sessiontype = $session->param('sessiontype') || ''; } + + warn $ip; + warn $ENV{REMOTE_ADDR}; if ( ( $query->param('koha_login_context') && ( $q_userid ne $s_userid ) ) || ( $cas && $query->param('ticket') && !C4::Context->userenv->{'id'} ) || ( $shib && $shib_login && !$logout && !C4::Context->userenv->{'id'} ) I get: After the login: $ip=undef, $ENV{REMOTE_ADDR}=192.168.254.1 After the click producing the logout: $ip=192.168.254.1, $ENV{REMOTE_ADDR}=127.0.0.1 After the second login: $ip=127.0.0.1, $ENV{REMOTE_ADDR}=127.0.0.1 -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 14525] undo checkin/out when accompanying message appears
by bugzilla-daemon＠bugs.koha-community.org 16 Feb '19

16 Feb '19

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14525 Joy Nelson <joy(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |joy(a)bywatersolutions.com --- Comment #3 from Joy Nelson <joy(a)bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 17101 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0