- Koha-bugs - lists.koha-community.org

[Bug 21673] New: Koha::Account::Lines->total_outstanding must be used when needed
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21673 Bug ID: 21673 Summary: Koha::Account::Lines->total_outstanding must be used when needed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 13098 There are several times the same pattern to retrieve the sum of amountoutstanding columns for Koha::Account::Line set. We should use Koha::Account::Lines->total_outstanding instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 [Bug 13098] Item lost multiple times by the same patron will create only be charged once -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82760|0 |1 is obsolete| | --- Comment #18 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 82826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82826&action=ed… Bug 10659: Upgrade jQuery star ratings plugin This patch replaces our current jQuery star ratings plugin with a newer plugin which will be compatible with newer versions of jQuery: http://antenna.io/demo/jquery-bar-rating/examples/ To test you should have one or more records in your catalog with star ratings. - Apply the patch and set the OpacStarRatings system preference to "results and details" - Perform a search in the catalog which will return one or more titles which have ratings. - Confirm that the ratings appear correctly and the ratings are read-only. - Open the "normal" detail page for that record. - Confirm that the star rating appears correctly. - Test setting and re-setting your star rating. Confirm that it is saved. - Confirm that the "cancel rating" link appears when you have a rating set, and that it disappears after you click it. - Test that the "only details" and disabled options of the OpacStarRatings preference work as they should. - Confirm that information about the plugin appears on the About page in the staff client, replacing the old star ratings plugin information. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10659] Upgrade jQuery star ratings plugin
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '18

03 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 529] Bug in updater when inserting new fields (updatedatabase script)
by bugzilla-daemon＠bugs.koha-community.org 01 Dec '18

01 Dec '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=529 Alex Bernier <alex.bernier(a)braillenet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.bernier(a)braillenet.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 19574] New: Wrong itemtype can be chosen when placing holds
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19574 Bug ID: 19574 Summary: Wrong itemtype can be chosen when placing holds Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andreas.hedstrom.mace(a)sub.su.se QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com With the syspref AllowHoldItemTypeSelection set to Allow, it is possible to add a hold for an itemtype that doesn’t actually exist at a specific branch. Say that branch A has two itemtypes: books and map, while branch B has three: books, map and audio book. It is possible to add a hold for branch A with itemtype audio book although there is no item with such an itemtype at this branch. This will cause an internal server error if you try to delete this faulty hold. To recreate: 1) Enable AllowHoldItemTypeSelection 2) Add, or find, a bibliographic record with at least two branches and at least two items with two different itemtypes. Branch B should not have all itemtypes. 3) Add a hold for branch B, and choose an itemtype not available at this branch (there are no such items) 4) Try deleting the hold, note the internal server error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82420|0 |1 is obsolete| | --- Comment #78 from Michal Denar <black23(a)gmail.com> --- Created attachment 82797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82797&action=ed… Bug 11373: Show the difference between the amount collected and the amount paid of a fine payment. This patch adds a feature in the fine payment section. It allows to see the change due to patrons when the amount collected is higher than the amount paid. Test plan : - Apply patch. - Select a patron with a fine. - Go to Fines > Pay fines. - Click the button pay. - Choose the amount paid equal to the outstanding amount (exemple : 3$). - Choose the amount collected to be more than the outstanding amount (exemple : 5$). - Confirm that the change is correct (example : 5$ - 3$ = 2$). - Click the button confirm. - Click on Yes in the dialog box. - Confirm that the payment has been made (example : last amount = 3$). Signed-off-by: Michal Denar <black23(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add "change calculation" feature to the fine payment forms
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Michal Denar <black23(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 21835] New: Request ID is displayed as NaN
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21835 Bug ID: 21835 Summary: Request ID is displayed as NaN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com In the main ILL requests table, the request ID is displayed as NaN. There are two problems here. Firstly, we're not populating id_prefix in the API response, it got missing in the deprecation of TO_JSON in bug 20996. As such, by the time we get to the JS that populates the ILL table, there is no id_prefix property in the row object, so concatenating undefined with an integer returns NaN. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 15

[Bug 14957] Write protecting MARC fields based on source of import
by bugzilla-daemon＠bugs.koha-community.org 30 Nov '18

30 Nov '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 David Gustafsson <glasklas(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #136 from David Gustafsson <glasklas(a)gmail.com> --- Rebased against master and added granular permission in accordance with Bug 14391. -- You are receiving this mail because: You are watching all bug changes.

1 0