- Koha-bugs - lists.koha-community.org

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81419|0 |1 is obsolete| | --- Comment #141 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81571&action=ed… Bug 15565: CSS changes Note: Reworked as we have switched to CSS since this commit was first written. This commit now contains 2 files: * koha-tmpl/opac-tmpl/bootstrap/css/opac.css * koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78815|0 |1 is obsolete| | --- Comment #140 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 81570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81570&action=ed… Bug 15565: Place multiple holds at once for the same record on staff and OPAC. Test plan: 1. Create an circulation rule to use for testing the patches on this bug report. Ensure it has a value greater than 1 for 'Holds allowed', 'Holds per record (count)', and 'Item level holds' is enabled. 2. Also ensure the 'RequestOnOpac' syspref is set to 'Allow'. 3. Go to the reservation page (request.pl) of a biblio in the staff client with more than one item. 4. Notice beside each item a radio button is displayed preventing you from being able to select multiple items to place a hold on. 5. Go to the reservation page (opac-reserve.pl) of the same biblio in the OPAC also notice a radio button is displayed beside every item. 6. Apply patches 7. Repeat step 3 and 5 and notice in both the staff client and OPAC checkboxes rather than radio buttons are displayed beside each item so you can select multiple items for reservation at a time. 8. From staff interface, place several item-level holds for the same user on the same record at once: - check that you are warned if you exceed "Holds per record (count)" (circulation rules) for this record. - check also maxReserves system preference. 9. From opac, place several item-level and record level holds for the same user on the same record at once: - check that can't exceed "Holds per record (count)" for this record. This is enforced by all unticked item checkboxes being disabled after the number of ticked checkboxes equals the 'Holds per record (count)' (circulation rules) value. - check also maxReserves system preference. Do the same in OPAC and staff by selecting several record (multi-hold). Signed-off-by: Séverine QUEUNE <severine.queune(a)bulac.fr> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Benjamin Rokseth <benjamin.rokseth(a)deichman.no> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15565] Place multiple holds at once for the same record in OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #20 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81543&action=ed… Bug 13098: Fix POD for Koha::Account::Offsets::total Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #19 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81542&action=ed… Bug 13098: Sum at DBMS level Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #18 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81541&action=ed… Bug 13098: Do not compare with precision Formating will be done TT side Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #17 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81540&action=ed… Bug 13098: Make _FixAccountForLostAndReturned refund the right thing This patch changes the logic inside the method, to make it match the behaviour described on the tests. It uses the existing offsets on the account_offsets table to gather information about the right things to refund. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests don't pass! - Apply this patch - Run k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Followed test plan, patch works as described. All three patches pass QA test tool Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13098] Item lost multiple times by the same patron will create only be charged once
by bugzilla-daemon＠bugs.koha-community.org 29 Oct '18

29 Oct '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098 --- Comment #16 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 81539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81539&action=ed… Bug 13098: Tests for all _FixAccountForLostAndReturned use cases This patch introduces tests for all the use cases for _FixAccountForLostAndReturned. This includes the following scenarios before _FixAccountForLostAndReturned is called: - Full write off (the original issue) - Full payment - No payment or write off - Partial payment and partial write off Written off debts (L lines) are just skipped, any kind of payment is added and then refund as a single credit (CR). Amount outstanding is set to 0. Offsets need to be generated for paper trail of this decisions. To test: - Run: $ kshell k$ prove t/db_dependent/Circulation.t => FAIL: Tests fail because _FixAccountForLostAndReturned is not doing the right thing :-D Followed test plan, patch works as described Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0