- Koha-bugs - lists.koha-community.org

[Bug 15219] Server-side processing and pagination on checkouts tables
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78555|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 79195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79195&action=ed… Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 Signed-off-by: Eric Gosselin <eric.gosselin(a)inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #46 from Josef Moravec <josef.moravec(a)gmail.com> --- Comment on attachment 79188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79188 Bug 11373: Add a "cash register" feature to the fine payment form. Review of attachment 79188: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=113…) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt @@ +75,5 @@ > + <div id="change_message" class="dialog message"> > + <span>The amount collected is greater than the total amount paid.</span><br /> > + <strong>Change to give back: [% give_change | $Price %]</strong><br /><br /> > + <input type="submit" name="submitbutton" value="Confirm payment" /> > + <a class="cancel" href="/cgi-bin/koha/members/pay.pl?borrowernumber=[% patron.borrowernumber %]">Cancel</a> use uri filter @@ +120,5 @@ > + [% IF ( give_change ) %] > + <li> > + <label for="paid">Amount paid:</label> > + <input type="hidden" name="paid" id="paid" value="[% amount_paid %]" /> > + <input type="hidden" name="collected" id="collected" value="[% amount_paid %]" /> use html filter @@ +134,5 @@ > + </li> > + [% ELSE %] > + <li> > + <label for="paid">Amount paid:</label> > + <input name="paid" id="paid" value="[% amountoutstanding | format('%.2f') %]" onchange="moneyFormat(document.payform.paid)"/> use $Price filter @@ +141,3 @@ > <li> > + <label for="collected">Collect from patron:</label> > + <input name="collected" id="collected" value="[% amountoutstanding %]" onchange="moneyFormat(document.payform.collected)" /> use $Price filter @@ +233,5 @@ > </li> > + [% IF ( give_change ) %] > + <li> > + <label for="paid">Amount paid:</label> > + <input type="hidden" name="paid" id="paid" value="[% amount_paid %]" /> use html filter @@ +238,5 @@ > + [% amount_paid | $Price %] > + </li> > + <li> > + <label>Collected from patron:</label> > + <input type="hidden" name="collected" id="collected" value="[% amount_paid %]" /> use html filter @@ +248,5 @@ > + </li> > + [% ELSE %] > + <li> > + <label for="paid">Amount paid :</label> > + <input name="paid" id="paid" value="[% total %]" onchange="moneyFormat(document.payform.paid)" /> use $Price filter @@ +259,3 @@ > [% END %] >  > + <input name="collected" id="collected" value="[% total %]" onchange="moneyFormat(document.payform.collected)"/> use $Price filter -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Josef Moravec <josef.moravec(a)gmail.com> --- The information on this page is duplicate: https://screenshots.firefox.com/o2GtPtGugLjtJSqq/localhost why do you even add the dialog? Also this could be enabled disabled, please add system preference for this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #44 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Josef Moravec from comment #43) > (In reply to Blou from comment #41) > > Fixed the rest, but for the padding in the button, we'll need to find > > another solution since an <input> under a class="dialog message" will show > > like that. Not sure why the staff.css specifies that padding, but clearly > > having a confirm button in a message dialog is not the standard Koha way. > > That is because you should have icon on that button - try to add a > class="approve" to button. And add the icon itself like this: <i class="fa fa-fw fa-check"></i> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |josef.moravec(a)gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11373] Add a "cash register" feature to the fine payment form
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373 --- Comment #43 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Blou from comment #41) > Fixed the rest, but for the padding in the button, we'll need to find > another solution since an <input> under a class="dialog message" will show > like that. Not sure why the staff.css specifies that padding, but clearly > having a confirm button in a message dialog is not the standard Koha way. That is because you should have icon on that button - try to add a class="approve" to button. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10060] Self Checkout module does not honour circ control
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10060 --- Comment #8 from Oliver Behnke <oliver.behnke(a)aei.mpg.de> --- (In reply to Katrin Fischer from comment #6) > Could using a separate self-check user for each branch solve the problem? Katrin, is this already possible or are you suggesting a new feature? I'd love to try that if it's already supported but I don't see how. Cheers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13640] Holds To Pull List includes items unreserveable items
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640 --- Comment #9 from Magnus Enger <magnus(a)libriotech.no> --- I think I managed to take the 'Default holds policy by item type' into account in this report: SELECT min(reservedate) as l_reservedate, reserves.reserve_id, reserves.borrowernumber as borrowernumber, GROUP_CONCAT(DISTINCT items.holdingbranch ORDER BY items.itemnumber SEPARATOR '|') l_holdingbranch, reserves.biblionumber, reserves.branchcode as l_branch, reserves.itemnumber, items.holdingbranch, items.homebranch, GROUP_CONCAT(DISTINCT items.itype ORDER BY items.itemnumber SEPARATOR '|') l_item_type, GROUP_CONCAT(DISTINCT items.location ORDER BY items.itemnumber SEPARATOR '|') l_location, GROUP_CONCAT(DISTINCT items.itemcallnumber ORDER BY items.itemnumber SEPARATOR '<br/>') l_itemcallnumber, GROUP_CONCAT(DISTINCT items.enumchron ORDER BY items.itemnumber SEPARATOR '<br/>') l_enumchron, GROUP_CONCAT(DISTINCT items.copynumber ORDER BY items.itemnumber SEPARATOR '<br/>') l_copynumber, biblio.title, biblio.author, count(DISTINCT items.itemnumber) as icount, count(DISTINCT reserves.borrowernumber) as rcount, borrowers.firstname, borrowers.surname FROM reserves LEFT JOIN items ON items.biblionumber=reserves.biblionumber LEFT JOIN biblio ON reserves.biblionumber=biblio.biblionumber LEFT JOIN biblioitems ON biblio.biblionumber=biblioitems.biblionumber LEFT JOIN branchtransfers ON items.itemnumber=branchtransfers.itemnumber LEFT JOIN issues ON items.itemnumber=issues.itemnumber LEFT JOIN borrowers ON reserves.borrowernumber=borrowers.borrowernumber LEFT JOIN default_branch_item_rules ON items.itype=default_branch_item_rules.itemtype WHERE reserves.found IS NULL AND (reserves.itemnumber IS NULL OR reserves.itemnumber = items.itemnumber) AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers where datearrived IS NULL) AND items.itemnumber NOT IN (select itemnumber FROM reserves where found IS NOT NULL) AND issues.itemnumber IS NULL AND reserves.priority <> 0 AND reserves.suspend = 0 AND notforloan = 0 AND damaged = 0 AND itemlost = 0 AND withdrawn = 0 AND default_branch_item_rules.holdallowed != 0 GROUP BY reserves.biblionumber ORDER BY biblio.title What is changed compared to the "Holds to pull" SQL are these two lines: - LEFT JOIN default_branch_item_rules ON items.itype=default_branch_item_rules.itemtype - AND default_branch_item_rules.holdallowed != 0 However, default_branch_item_rules.holdallowed is of the "bit" type: http://schema.koha-community.org/18_05/tables/default_branch_item_rules.html I gotta confess I'm not familiar with that. Any special tricks to consider? When I look in the database, the value of that column is 0 or 2. Why not a boolean "0 or 1" value? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 20806] New: Column settings issues for holdshistory-table
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20806 Bug ID: 20806 Summary: Column settings issues for holdshistory-table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: severine.queune(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com There is 2 display issues with the table "Holds history" tab : - no change when modifying "Column settings > Patrons > (id=holdshistory-table)". I don't know if it is linked, but the <table id> on the tab is "table_holdshistory". - column "Item type" is always empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 29

[Bug 20079] New: Display stack trace for development installations
by bugzilla-daemon＠bugs.koha-community.org 21 Sep '18

21 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Bug ID: 20079 Summary: Display stack trace for development installations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Starman -E should be development instead of deployment for dev installs -- You are receiving this mail because: You are watching all bug changes.

1 14