- Koha-bugs - lists.koha-community.org

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '18

12 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '18

12 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #10 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 78582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78582&action=ed… Bug 15529 - Locking process_message_queue.pl cron whilst it is running This amended patch is called by koha-common. koha-common runs this process_message_queue.pl cronjob foreach enabled Koha instance on the server. As this cronjob is run for every Koha instance the retrival of all Koha instance names from debian/scripts/koha-scripts in previous obsolete patches on this bug report and the looping through every name to check if the lock file existed is redundant. Instead this patch retrieves the 'logdir' of the Koha instance being iterated over and checks if the messagequeue.lock file in that directory is locked. If the aforementioned file is not locked then the SendQueuedMessages() in C4/Letters.pm is called, otherwise an email is sent (to the manually inputted email server, and to/from addresses) and duplicate execution of the cronjob is prevented. Test plan: 1. In two terminals open koha-shell and try to run ./process_message_queue.pl and notice you can run the script multiple times simulataneously without a warning/error being displayed 2. Apply patch and input the email server, to/from email addresses you would like the email to be sent to. Also confirm your Koha instance is enabled to send emails. 3. Repeat step 1 and notice that the second of the two scripts to be run will output text saying './process_message_queue.pl is already running. Exiting' In this case the aforementioned text is displayed and the body of the cronjob is not run. 4. The first cronjob script to run, runs without issues 5. At the end of the execution of the first script a 15 second pause is run 6. Notice you have received an email Sponsored-By: New Zealand Parliamentary Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15529] Process Message Queue may send duplicate emails if process is launched twice
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '18

12 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78212|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '18

11 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #173 from David Cook <dcook(a)prosentient.com.au> --- I was reviewing the test plan above and realized that https://gitlab.com/koha-community/koha-testing-docker probably won't work for testing this because it uses koha-gitify, and 10662 changes configuration files which requires a full Koha build... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '18

11 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #172 from David Cook <dcook(a)prosentient.com.au> --- Rebased against master. Going to test this using https://gitlab.com/koha-community/koha-testing-docker later. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '18

11 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71015|0 |1 is obsolete| | --- Comment #171 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 78577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78577&action=ed… Fix problems reported by Koha QA tools -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '18

11 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71014|0 |1 is obsolete| | --- Comment #170 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 78576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78576&action=ed… Use old style of UUID generation -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '18

11 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71013|0 |1 is obsolete| | --- Comment #169 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 78575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78575&action=ed… Standardize OAI-PMH test success/failure -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '18

11 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71012|0 |1 is obsolete| | --- Comment #168 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 78574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78574&action=ed… Fix configuration typo for Debian instances -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 11 Sep '18

11 Sep '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71011|0 |1 is obsolete| | --- Comment #167 from David Cook <dcook(a)prosentient.com.au> --- Created attachment 78573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78573&action=ed… Add RDF::Query dependency -- You are receiving this mail because: You are watching all bug changes.

1 0