- Koha-bugs - lists.koha-community.org

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77220&action=ed… Bug 15520: Rename permission to manage_circ_rules_from_any_libraries -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77202|0 |1 is obsolete| | Attachment #77203|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77219&action=ed… Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. Amended by JD: In a second version of this patch manage_circ_rules_restricted has been replaced by manage_circ_rules_from_any_libraries and 'no_inherit' related code has been removed -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #40) > > > After that is done, the code in CanItemBeReserved could be replaced with a > > > call to GetBranchBorrowerCircRule. > > This is, I think, still a valid request/question. > In CanItemBeReserved there are 2 Koha::CirculationRules->find > I am wondering why we do not call Koha::CirculationRules->get_effective_rule > instead. > Moreover it seems that there is a mix between '*' and undef. The UI inserts > '*' whereas these calls and the tests search for undef. > If we use undef we will be able to add FKs > (branchcode,categorycode,itemtype) which can be great. And this is for bug 18887. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15524] Set limit on maximum possible holds per patron by category
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Back to this. (In reply to Kyle M Hall from comment #39) > (In reply to Jonathan Druart from comment #38) > > Kyle, > > > > Go to "Default checkout, hold and return policy", you do not see "Total > > holds allowed", fill the other fields, save: default_circ_rules.holdallowed > > is filled. > > We could add it to the interface and make it configurable, do not you think? > > holdallowed doesn't define how many holds may be placed, it defines what > items a patron may place holds on. It's already revealed in the rules editor! > > > > > Also if we add "max_holds", maybe we should rename "holdallowed" then. > > Again, not the same thing. Well, I think you were right here. I do not understand what I wanted to tell. I guess I got holdallowed and max_holds mixed up. Sorry about that. > > After that is done, the code in CanItemBeReserved could be replaced with a > > call to GetBranchBorrowerCircRule. This is, I think, still a valid request/question. In CanItemBeReserved there are 2 Koha::CirculationRules->find I am wondering why we do not call Koha::CirculationRules->get_effective_rule instead. Moreover it seems that there is a mix between '*' and undef. The UI inserts '*' whereas these calls and the tests search for undef. If we use undef we will be able to add FKs (branchcode,categorycode,itemtype) which can be great. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 17785] New: oai.pl returns wrong URLs under Plack
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17785 Bug ID: 17785 Summary: oai.pl returns wrong URLs under Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org oai.pl uses CGI's self_url Under Plack this results in an URL like: /opac/oai.pl?verb=ListRecords&resumptionToken=marcxml/100/1970-01-01T00:00:00Z/2016-12-16T23:59:59Z/ (This is the URL for the More button.) Should we adjust the mounting point and ProxyPass statements? Mount like /cgi-bin/koha/opac ? -- You are receiving this mail because: You are watching all bug changes.

1 28

[Bug 21109] New: oai.pl returns invalid resumptionToken cursor
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21109 Bug ID: 21109 Summary: oai.pl returns invalid resumptionToken cursor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P4 Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: pablo.bianchi(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 21102 Tested with https://github.com/zimeon/oaipmh-validator and curl -s "baseURL?verb=ListRecords&metadataPrefix=oai_dc" | xmllint --format - | grep resumptionToken ### Checking for correct use of resumptionToken (if used) REQUEST: baseURL?verb=ListRecords&metadataPrefix=oai_dc GET FAIL: A cursor value was supplied with the resumptionToken but it did not have the correct value zero for the first response. The value was '50'. This value is OAI-PMH:MaxCount syspref. _cursor_ indicate the number of previous replies have already delivered: "cursor -- a count of the number of elements of the complete list thus far returned (i.e. cursor starts at 0)." See https://www.openarchives.org/OAI/openarchivesprotocol.html#FlowControl See https://www.openarchives.org/OAI/2.0/guidelines-harvester.htm#resumptionTok… Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 21108] New: oai.pl error response did not contain error code 'noRecordsMatch' when it should
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21108 Bug ID: 21108 Summary: oai.pl error response did not contain error code 'noRecordsMatch' when it should Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: pablo.bianchi(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Blocks: 21102 Tested with https://github.com/zimeon/oaipmh-validator ### Checking for version 2.0 specific exceptions REQUEST: baseURL?verb=ListRecords&metadataPrefix=oai_dc&until=-001 GET FAIL: Error code noRecordsMatch not found in response but should be given to the request: verb=ListRecords&metadataPrefix=oai_dc&until=-001 The request specified a date one year before the earliestDatestamp given in the Identify response. There should therefore not be any records with datestamps on or before this date and a noRecordsMatch error code should be returned. See https://www.openarchives.org/OAI/openarchivesprotocol.html#ErrorConditions and 4.3 ListIdentifiers Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21102 [Bug 21102] OAI-PMH specification conformance [UMBRELLA] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I have removed unnecessary code from the first version and provide a second patch to rename the permission as well as adjust the code. Ready for testing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #19 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77203&action=ed… Bug 15520: Rename permission to manage_circ_rules_from_any_libraries -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15520] Add more granular permission for only editing own library's circ rules
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '18

24 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72240|0 |1 is obsolete| | Attachment #72241|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 77202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77202&action=ed… Bug 15520: Add permission to restrict circ rules editing to own library Test plan: 1) Ensure that you have four users: a) A superlibrarian b) A user with all `parameters` permissions (the toplevel `parameters` box is checked). c) A user with the `manage_circ_rules` permission (and, of course, `catalogue`). d) A user with the `manage_circ_rules`, `manage_circ_rules_restricted` and `catalogue` permissions. 2) As all four users, load the "Circulation and fine rules" administration page (admin/smart-rules.pl). 3) The page should be unchanged for the first three users. It should be possible to view and edit the circ rules for all libraries. 4) The last (restricted) user should only be able to view and edit the circ rules for their own library. Amended by JD: In a second version of this patch manage_circ_rules_restricted has been replaced by manage_circ_rules_from_any_libraries and 'no_inherit' related code has been removed -- You are receiving this mail because: You are watching all bug changes.

1 0