- Koha-bugs - lists.koha-community.org

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '18

09 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76690|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 76779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76779&action=ed… Bug 8604: Patron cards made for patrons which don't have patron images use preceding card's image This patch corrects referential problems which caused the script to "re-use" images as well as other sorts of bad image behaviour. To test: 1. Ensure that you can reproduce the original bug or some variation thereof using the steps described in either of these two comments: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c0 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604#c6 NOTE: This is not an easy bug to reproduce. 2. Once you can reproduce the bug, apply this patch and follow the same steps used to reproduce the bug. 3. Observe that the symptoms are corrected. Signed-off-by: Chris Nighswonger <cnighswonger(a)foundations.edu> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image
by bugzilla-daemon＠bugs.koha-community.org 09 Jul '18

09 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10442] Remove references to non-standard "error" class
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '18

08 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10442 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch doesn't apply, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '18

08 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 4) Editing a note no longer works! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12365] Notes for rules
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '18

08 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Aleisha, thx for the follow-up! Some notes: 1) I'd like to see "click to view note" changed to just "view note". As the text is formatted as a link, there should be no need to add the additional instruction. 2) When there are multiple lines with notes and you click on one of them, they will just overlay each other, with the first note being behind the second and so on, There seems to be no way to make them disappear again. I think my expectation was that the note would disappear clicking on the next note or just clicking outside the note field again. A longer note can also overlay the buttons, so I think putting some more thought into this would be worthwhile. 3) Tiny: Can you make your patch subject: Bug XXXX: (follow-up)? I would have fixed it as part of QA, but then stumbled on 2). (see: https://wiki.koha-community.org/wiki/Commit_messages#Follow-ups) Thx! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15326] Add CMS feature
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '18

08 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #36 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Trying to tackle this: 1) QA scripts Only the second looks valid, as this class is new and added by the patch set: FAIL Koha/CmsPage.pm FAIL pod coverage POD coverage was greater before, try perl FAIL Koha/CmsPages.pm FAIL pod coverage POD is missing for 'object_class' FAIL Koha/Schema/Result/CmsPage.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Can you please fix? 2) Code review a) Schema patches would be much better in a separate patch. Ok for now as the patch still applies. For a rebase separating those change might be good. b) In opac-cmspages there is: + flagsrequired => { borrow => 1 }, The borrow permission has been removed since. (blocker) c) Comment was removed unnecessarily, just needs to be moved into its right spot below again: -# If GoogleIndicTransliteration system preference is On Set parameter to load Google's javascript in OPAC search screens d) One file uses qw( -utf-8) but another does not: +use CGI; +use CGI qw( -utf8 ); (blocker) 3) Unit tests ... all passing! 4) Feature tests OPAC a) I feel we don't need the "Pages" heading. It only takes up space and states the obvious. (non-blocker... but navigation needs work, see below) b) OpacMainUserBlock should not show on the pages in my opinion. Libraries use it to place text on the start page instead of using the news feature, which means it repeats on all pages. I'd really like to see this changed. c) Personally I'd change "Location" to "Interface" to avoid confusion with the item value in translations. But I see it's the same on news. So out of scope here. d) Parent pages can be deleted without warning. Childs will be moved to top level. This is acceptable behaviour as they are not left orphaned. But it might be something to improve on in the future. e) In the test plan and in the code I see there should be a confirmation message on deleting a single or multiple entries, but this doesn't work. (blocker) f) Navigation looks strange when working with multiple levels. Repeating the level before seems unnecessary and only takes up space? Level 1 Level 1 › Level 2 Level 2 › Level 3 Also, clicking on the different links, sometimes a part of the navigation disappears. I think this is a little too wonky to pass. Can you take another look please? (blocker) Intranet Where do the pages appear in the intranet? Generally I think this will be a great and really helpful addition and looking forward to return to this! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '18

08 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 76756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76756&action=ed… Bug 14446: Workaround to resolve uninitialized value in goto warning Forcing both GetTab calls to list context resolves the warning. A workaround, not a real fix. Test plan: Search for something in the syspref text bar. Without this patch, you will have a warn: Use of uninitialized value in goto With this patch, you won't. Signed-off-by: Aleisha Amohia <aleishaamohia(a)hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl
by bugzilla-daemon＠bugs.koha-community.org 08 Jul '18

08 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6647] Label item search should use standard pagination routine
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '18

07 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Stumbled on bug 21050 while testing this. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 6647] Label item search should use standard pagination routine
by bugzilla-daemon＠bugs.koha-community.org 07 Jul '18

07 Jul '18

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6647 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76748|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 76750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76750&action=ed… Bug 6647: Label item search should use standard pagination routine This patch doesn't fix how pagination links are generated for the label item search results, but it does modify the template so that the pagination links are styled like they are on catalog search results. To test, apply the patch and go to Tools -> Labels. - Open or create a label batch. - Click "Add items" to trigger the pop-up search window. - Perform a search which would return multiple results. - Confirm that the style of the pagination bar matches the one on the catalog search results page. - Confirm that current-page number highlighting works correctly. Signed-off-by: Maryse Simard <maryse.simard(a)inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0